From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB255C433E0 for ; Tue, 9 Jun 2020 15:51:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 936BC2072F for ; Tue, 9 Jun 2020 15:51:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VAL71rjp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730986AbgFIPv1 (ORCPT ); Tue, 9 Jun 2020 11:51:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730603AbgFIPv1 (ORCPT ); Tue, 9 Jun 2020 11:51:27 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 993CBC05BD1E; Tue, 9 Jun 2020 08:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vC8V+aEno7HGDbaQpVa4ZBc8i79Usy689nIDntg7S3Y=; b=VAL71rjpnJm1wjZrTaRm0cyHc+ Lu7Palz6Uv26rhNL5PglxtMJfNtnk4wM6LuwN+LFfR1soMcZSKT5/wqpb0PV5BoHkrC48JpkrmuDI yNh2oWICb96YEFv3oSt4q+ZgncoiC3ePWVXSxIWMT5tKMYVqPaCRhsWT2P6T5uz0Yjo9NdRyTV5VZ wewZ2C+xjpvEre+j4hOP7R6RMq5gCDYVSDxDmxCtYXYRKkBlvbGrO2IkOo7RFvMC7HYv6FZDRQBFl 42VLjDtvgGV0AuxzA25TmoEr9QeG/k1E4OVJcjtt+4W58IquDw67QFzsyrJ+JMyYBiAmgzGBm12Sb u2zdDHUw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jigX6-0003SL-TY; Tue, 09 Jun 2020 15:51:24 +0000 Date: Tue, 9 Jun 2020 08:51:24 -0700 From: Christoph Hellwig To: Piotr Stankiewicz Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Kurt Schwemmer , Logan Gunthorpe , Mika Westerberg , "Rafael J. Wysocki" , Andy Shevchenko , Olof Johansson , Kuppuswamy Sathyanarayanan , Kelvin Cao , Wesley Sheng , "Peter Zijlstra (Intel)" , Krzysztof Wilczynski , Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/15] PCI: Use PCI_IRQ_MSI_TYPES where appropriate Message-ID: <20200609155124.GB2597@infradead.org> References: <20200609091148.32749-1-piotr.stankiewicz@intel.com> <20200609091650.801-1-piotr.stankiewicz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200609091650.801-1-piotr.stankiewicz@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2020 at 11:16:46AM +0200, Piotr Stankiewicz wrote: > Seeing as there is shorthand available to use when asking for any type > of interrupt, or any type of message signalled interrupt, leverage it. > > Signed-off-by: Piotr Stankiewicz > Reviewed-by: Andy Shevchenko > Reviewed-by: Logan Gunthorpe The patch actually adding PCI_IRQ_MSI_TYPES still didn't show up on linux-pci. But from the person who added PCI_IRQ_*: NAK to the whole concept of PCI_IRQ_MSI_TYPES, I think this just makes the code a lot more confusing. Especially with the new IMS interrupt type, which really is a MSI-like interrupt but certainly shouldn't be added to this mask.