From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0065BC433DF for ; Tue, 9 Jun 2020 18:03:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA7BA206D5 for ; Tue, 9 Jun 2020 18:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591725795; bh=d6DNbeK+qZmskXZLjAOxdDEj9eIiTEaY0hausGND4U0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rhexGHtJD+DBEQXNDXYN1voXCvgnvnWaVcsvmp5qSbjAQo1ROOmPTQYb5OPMMMJQ/ AXDbBZJd1CV1S7pOq6N4tAI2skbICO0j3NHnbMkcjkZq3mGjUOA7dX+PZQAsQPg1ky xSCtfqtWi6yV+amqHoMcsopZQDbDyPETYqRdIQwQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732962AbgFIRxA (ORCPT ); Tue, 9 Jun 2020 13:53:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:41642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730980AbgFIRvx (ORCPT ); Tue, 9 Jun 2020 13:51:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40FB520774; Tue, 9 Jun 2020 17:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591725113; bh=d6DNbeK+qZmskXZLjAOxdDEj9eIiTEaY0hausGND4U0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gzA5p/+n6cnZJuXBlEeXz3lrS16C4Pe66RXip8vlzH9zeq7vJFA7JGbr1/EAyPQlD gf8wl/e+SnCpBOuJEOxvuZOAH8YXINPwUX//6Nx/duXMWFRuOXP5SsHpNhJS/mRLf1 y3U5NwCmsQp4VCZdiFz5qUO5/8ZWU5iRBTQ7OOz0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bin Liu , Johan Hovold Subject: [PATCH 4.19 09/25] USB: serial: usb_wwan: do not resubmit rx urb on fatal errors Date: Tue, 9 Jun 2020 19:44:59 +0200 Message-Id: <20200609174049.714293801@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200609174048.576094775@linuxfoundation.org> References: <20200609174048.576094775@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bin Liu commit 986c1748c84d7727defeaeca74a73b37f7d5cce1 upstream. usb_wwan_indat_callback() shouldn't resubmit rx urb if the previous urb status is a fatal error. Or the usb controller would keep processing the new urbs then run into interrupt storm, and has no chance to recover. Fixes: 6c1ee66a0b2b ("USB-Serial: Fix error handling of usb_wwan") Cc: stable@vger.kernel.org Signed-off-by: Bin Liu Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/usb_wwan.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/serial/usb_wwan.c +++ b/drivers/usb/serial/usb_wwan.c @@ -299,6 +299,10 @@ static void usb_wwan_indat_callback(stru if (status) { dev_dbg(dev, "%s: nonzero status: %d on endpoint %02x.\n", __func__, status, endpoint); + + /* don't resubmit on fatal errors */ + if (status == -ESHUTDOWN || status == -ENOENT) + return; } else { if (urb->actual_length) { tty_insert_flip_string(&port->port, data,