From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A22DC433DF for ; Wed, 10 Jun 2020 07:08:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB1F6207ED for ; Wed, 10 Jun 2020 07:08:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="LaT2eRoY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbgFJHIc (ORCPT ); Wed, 10 Jun 2020 03:08:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbgFJHIb (ORCPT ); Wed, 10 Jun 2020 03:08:31 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC23EC03E96B; Wed, 10 Jun 2020 00:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Uz81Z+0BCBNqLv4PQFmkR/zfQQ+FgD1974AzuRQ6XTg=; b=LaT2eRoYttZjSzfpscy3GH1Bgz cmrv+2X+EcRvPARdeRGxi2ZZcElfyYLyNY2gOPbjMH73bC0SzCvdWQaUnQNsbhjSN/l7EFvwDl4id hoM9IzulHRSVPoeXuND/BBiPWYi9/RhduLG9jFdKRjd8bSSqp1ipDXmUJf69Pi98QGXr19JrqA+L7 v/W1ZPdsemFSgMZyfVjcRiKeGAC7q50Hu/5I6WfF1QZkoY60Xtfpyt4xru99E+235tv+GK67GHivH CXXj0VDiU/As2RT5RzLxmAwzXA+c0lEW6iaWluKaK5SeLH36uzj4PNJF/ePxJ071DRjKrW7iWA5MQ 4KIoTAKQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiuqa-00086x-9d; Wed, 10 Jun 2020 07:08:28 +0000 Date: Wed, 10 Jun 2020 00:08:28 -0700 From: Christoph Hellwig To: Piotr Stankiewicz Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Jonathan Corbet , Andrew Murray , Logan Gunthorpe , Andy Shevchenko , Zenghui Yu , Kelsey Skunberg , "Rafael J. Wysocki" , Krzysztof Wilczynski , Kuppuswamy Sathyanarayanan , Heiner Kallweit , Herbert Xu , Yicong Yang , Denis Efremov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/15] PCI: Add macro for message signalled interrupt types Message-ID: <20200610070828.GA29678@infradead.org> References: <20200609091148.32749-1-piotr.stankiewicz@intel.com> <20200609162243.9102-1-piotr.stankiewicz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200609162243.9102-1-piotr.stankiewicz@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2020 at 06:22:40PM +0200, Piotr Stankiewicz wrote: > There are several places in the kernel which check/ask for MSI or MSI-X > interrupts. It would make sense to have a macro which defines all types > of message signalled interrupts, to use in such situations. Add > PCI_IRQ_MSI_TYPES, for this purpose. To state my objection voices in patch 3 here again: I think this is a very bad idea. Everyone knows what MSI and MSI-X mean and that directly maps to specification. The new IMS interrupt scheme from the Intel SIOV spec for example is a message signalled interrupt type as well and should not be picked up automatically. If we want to change anything in this area we should probably remove PCI_IRQ_ALL_TYPES instead..