From: Luis Chamberlain <mcgrof@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
x86-ml <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] x86/microcode: Do not select FW_LOADER
Date: Wed, 10 Jun 2020 14:01:38 +0000 [thread overview]
Message-ID: <20200610140138.GU11244@42.do-not-panic.com> (raw)
In-Reply-To: <20200610134650.GH14118@zn.tnic>
On Wed, Jun 10, 2020 at 03:46:50PM +0200, Borislav Petkov wrote:
> On Wed, Jun 10, 2020 at 01:12:09PM +0000, Luis Chamberlain wrote:
> > On Wed, Jun 10, 2020 at 10:16:09AM +0200, Borislav Petkov wrote:
> > >
> > > Also, I'm working on removing that homegrown get_builtin_firmware() and
> > > use the one in the fw loader:
> > >
> > > https://lkml.kernel.org/r/20200408094526.GC24663@zn.tnic
> >
> > I would like to still encourage this, even with this patch in place,
> > as I think it makes this a proper call, and reflects better how the
> > firmware loader is used exactly.
> >
> > FWIW, firmware loader will be changed soon to not be modular, and just
> > built-in or disabled.
>
> I don't mind doing the work but Herbert has a point - there's no need to
> require a bunch of code for a trivial function.
>
> What I could do in addition is move that trivial function into a
> fw-specific header and have it defined unconditionally so that the
> microcode loader can use it without needing the fw loader.
Would just have to see this part. But sounds like a better place than
today.
> The testcases stuff then goes ontop.
Sure!
Luis
next prev parent reply other threads:[~2020-06-10 14:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 4:29 [PATCH] x86/microcode: Do not select FW_LOADER Herbert Xu
2020-06-10 8:16 ` Borislav Petkov
2020-06-10 10:28 ` Herbert Xu
2020-06-10 10:34 ` Borislav Petkov
2020-06-10 10:41 ` Herbert Xu
2020-06-10 10:48 ` Borislav Petkov
2020-06-10 11:05 ` [v2 PATCH] " Herbert Xu
2020-06-10 13:12 ` [PATCH] " Luis Chamberlain
2020-06-10 13:46 ` Borislav Petkov
2020-06-10 14:01 ` Luis Chamberlain [this message]
2020-06-15 10:03 ` [tip: x86/microcode] " tip-bot2 for Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610140138.GU11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).