* [PATCH] USB: ohci-sm501: Add missed iounmap() in remove
@ 2020-06-10 2:48 Chuhong Yuan
2020-06-10 14:09 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2020-06-10 2:48 UTC (permalink / raw)
Cc: Alan Stern, Greg Kroah-Hartman, Magnus Damm, linux-usb,
linux-kernel, Chuhong Yuan
This driver misses calling iounmap() in remove to undo the ioremap()
called in probe.
Add the missed call to fix it.
Fixes: f54aab6ebcec ("usb: ohci-sm501 driver")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/usb/host/ohci-sm501.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
index cff965240327..b91d50da6127 100644
--- a/drivers/usb/host/ohci-sm501.c
+++ b/drivers/usb/host/ohci-sm501.c
@@ -191,6 +191,7 @@ static int ohci_hcd_sm501_drv_remove(struct platform_device *pdev)
struct resource *mem;
usb_remove_hcd(hcd);
+ iounmap(hcd->regs);
release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
usb_put_hcd(hcd);
mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] USB: ohci-sm501: Add missed iounmap() in remove
2020-06-10 2:48 [PATCH] USB: ohci-sm501: Add missed iounmap() in remove Chuhong Yuan
@ 2020-06-10 14:09 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2020-06-10 14:09 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Greg Kroah-Hartman, Magnus Damm, linux-usb, linux-kernel
On Wed, Jun 10, 2020 at 10:48:44AM +0800, Chuhong Yuan wrote:
> This driver misses calling iounmap() in remove to undo the ioremap()
> called in probe.
> Add the missed call to fix it.
>
> Fixes: f54aab6ebcec ("usb: ohci-sm501 driver")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/usb/host/ohci-sm501.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
> index cff965240327..b91d50da6127 100644
> --- a/drivers/usb/host/ohci-sm501.c
> +++ b/drivers/usb/host/ohci-sm501.c
> @@ -191,6 +191,7 @@ static int ohci_hcd_sm501_drv_remove(struct platform_device *pdev)
> struct resource *mem;
>
> usb_remove_hcd(hcd);
> + iounmap(hcd->regs);
> release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
> usb_put_hcd(hcd);
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> --
> 2.26.2
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-10 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-10 2:48 [PATCH] USB: ohci-sm501: Add missed iounmap() in remove Chuhong Yuan
2020-06-10 14:09 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).