linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout
@ 2020-06-04 18:24 Markus Elfring
  2020-06-09 15:50 ` gubbaven
  2020-06-10 14:54 ` Greg KH
  0 siblings, 2 replies; 3+ messages in thread
From: Markus Elfring @ 2020-06-04 18:24 UTC (permalink / raw)
  To: Venkata Lakshmi Narayana Gubba, linux-arm-msm, linux-bluetooth
  Cc: Balakrishna Godavarthi, hemantg, Johan Hedberg, Marcel Holtmann,
	Matthias Kaehlcke, Rocky Liao, Rob Herring, Sean Paul,
	Claire Chang, yshavit, linux-kernel, kernel-janitors

> Due to race conditions between qca_hw_error and qca_controller_memdump
> during SSR timeout,the same pointer is freed twice.

This is an unfortunate software situation.


> Which results to double free error.

How do you think about to omit this sentence from the change description?


> Now a lock is acquired while SSR state moved to timeout.

I suggest to convert this information into an imperative wording.

Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout
  2020-06-04 18:24 [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout Markus Elfring
@ 2020-06-09 15:50 ` gubbaven
  2020-06-10 14:54 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: gubbaven @ 2020-06-09 15:50 UTC (permalink / raw)
  To: Markus Elfring
  Cc: linux-arm-msm, linux-bluetooth, Balakrishna Godavarthi, hemantg,
	Johan Hedberg, Marcel Holtmann, Matthias Kaehlcke, Rocky Liao,
	Rob Herring, Sean Paul, Claire Chang, yshavit, linux-kernel,
	kernel-janitors

Hi Markus,

Sure we will update in next patch set.

Regards,
Lakshmi Narayna.
On 2020-06-04 23:54, Markus Elfring wrote:
>> Due to race conditions between qca_hw_error and qca_controller_memdump
>> during SSR timeout,the same pointer is freed twice.
> 
> This is an unfortunate software situation.
> 
> 
>> Which results to double free error.
> 
> How do you think about to omit this sentence from the change 
> description?
> 
> 
>> Now a lock is acquired while SSR state moved to timeout.
> 
> I suggest to convert this information into an imperative wording.
> 
> Would you like to add the tag “Fixes” to the commit message?
> 
> Regards,
> Markus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout
  2020-06-04 18:24 [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout Markus Elfring
  2020-06-09 15:50 ` gubbaven
@ 2020-06-10 14:54 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-06-10 14:54 UTC (permalink / raw)
  To: Markus Elfring
  Cc: Venkata Lakshmi Narayana Gubba, linux-arm-msm, linux-bluetooth,
	Balakrishna Godavarthi, hemantg, Johan Hedberg, Marcel Holtmann,
	Matthias Kaehlcke, Rocky Liao, Rob Herring, Sean Paul,
	Claire Chang, yshavit, linux-kernel, kernel-janitors

On Thu, Jun 04, 2020 at 08:24:34PM +0200, Markus Elfring wrote:
> > Due to race conditions between qca_hw_error and qca_controller_memdump
> > during SSR timeout,the same pointer is freed twice.
> 
> This is an unfortunate software situation.
> 
> 
> > Which results to double free error.
> 
> How do you think about to omit this sentence from the change description?
> 
> 
> > Now a lock is acquired while SSR state moved to timeout.
> 
> I suggest to convert this information into an imperative wording.
> 
> Would you like to add the tag “Fixes” to the commit message?
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-10 14:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 18:24 [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout Markus Elfring
2020-06-09 15:50 ` gubbaven
2020-06-10 14:54 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).