From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FCEC433DF for ; Wed, 10 Jun 2020 14:55:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D07E5207C3 for ; Wed, 10 Jun 2020 14:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591800901; bh=gjvlNmhpOseNaDKedcB9GHU7iTHrdoxsgDi+ecT5hyM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Xd/5sTONdj23b2z+N7UuXKq/rqfrbkAxDg7kjPSvLQCLMBp08hsG29vve7gIoBEgY Vez88Avq4NC9+B+/thU2O/gNKWULkozIBfN0SxhQelwBdXeqVOIgaFRZWGkvy7+edg X4cy/x2K5dF+Bwc0egqHNCydPWZ/K24ABquPr9vI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729957AbgFJOzA (ORCPT ); Wed, 10 Jun 2020 10:55:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:44328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726908AbgFJOzA (ORCPT ); Wed, 10 Jun 2020 10:55:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B3B72072F; Wed, 10 Jun 2020 14:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591800899; bh=gjvlNmhpOseNaDKedcB9GHU7iTHrdoxsgDi+ecT5hyM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eaeuDZE9aPFGn7KUakOuZK2k1QhfcTOZLuINf4/XMi0YBL2klsbQOOY/l8bGW+4cz xp8VmKc3npL/FqyHiYEsi9FrCqkVBqhg2nuXSwGlsN/uPAw9BC+i5XucyjYDMT6Z/p TngvQfYG7+VgaLUpoauO2RAJo+iYFHoVAzhSxWPA= Date: Wed, 10 Jun 2020 16:54:53 +0200 From: Greg KH To: Markus Elfring Cc: Venkata Lakshmi Narayana Gubba , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, Balakrishna Godavarthi , hemantg@codeaurora.org, Johan Hedberg , Marcel Holtmann , Matthias Kaehlcke , Rocky Liao , Rob Herring , Sean Paul , Claire Chang , yshavit@google.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout Message-ID: <20200610145453.GC2102023@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 04, 2020 at 08:24:34PM +0200, Markus Elfring wrote: > > Due to race conditions between qca_hw_error and qca_controller_memdump > > during SSR timeout,the same pointer is freed twice. > > This is an unfortunate software situation. > > > > Which results to double free error. > > How do you think about to omit this sentence from the change description? > > > > Now a lock is acquired while SSR state moved to timeout. > > I suggest to convert this information into an imperative wording. > > Would you like to add the tag “Fixes” to the commit message? > > Regards, > Markus Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot