From: Michal Kubecek <mkubecek@suse.cz>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
"John W. Linville" <linville@tuxdriver.com>,
David Jander <david@protonic.nl>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
mkl@pengutronix.de, Marek Vasut <marex@denx.de>,
Christian Herber <christian.herber@nxp.com>,
Amit Cohen <amitc@mellanox.com>,
Petr Machata <petrm@mellanox.com>
Subject: Re: [PATCH v4 0/3] Add support for SQI and master-slave
Date: Wed, 10 Jun 2020 22:05:35 +0200 [thread overview]
Message-ID: <20200610200535.zkozejqc3ssxpeam@lion.mk-sys.cz> (raw)
In-Reply-To: <20200610083744.21322-1-o.rempel@pengutronix.de>
On Wed, Jun 10, 2020 at 10:37:41AM +0200, Oleksij Rempel wrote:
> This patch set is extending ethtool to make it more usable on automotive
> PHYs like NXP TJA11XX.
>
> They make use of new KAPI (currently in net-next, will go probably to the
> kernel 5.8-rc1):
> - PHY master-slave role configuration and status informaton. Mostly needed
> for 100Base-T1 PHYs due the lack of autonegatiation support.
> - Signal Quality Index to investigate cable related issues.
>
> changes v4:
> - rebase is against current ethtool master
> - pull headers from current kernel master
> - use tabs instead of spaces in the manual
>
> changes v3:
> - rename "Port mode" to "master-slave"
> - use [preferred|forced]-[master|slave] for information and
> configuration
>
> changes v2:
> - add master-slave information to the "ethtool --help" and man page
> - move KAPI update changes to the separate patch.
>
> Oleksij Rempel (3):
> update UAPI header copies
> netlink: add master/slave configuration support
> netlink: add LINKSTATE SQI support
>
> ethtool.8.in | 19 +++++
> ethtool.c | 1 +
> netlink/desc-ethtool.c | 4 +
> netlink/settings.c | 66 +++++++++++++++
> uapi/linux/ethtool.h | 16 +++-
> uapi/linux/ethtool_netlink.h | 153 ++++++++++++++++++++++++++++++++++-
> uapi/linux/genetlink.h | 2 +
> uapi/linux/if_link.h | 1 +
> uapi/linux/netlink.h | 103 +++++++++++++++++++++++
> uapi/linux/rtnetlink.h | 6 ++
> 10 files changed, 369 insertions(+), 2 deletions(-)
>
> --
> 2.27.0
>
The series looks good to me, I'll wait for another day or two for other
comments and apply it there are no objections.
Michal
next prev parent reply other threads:[~2020-06-10 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 8:37 [PATCH v4 0/3] Add support for SQI and master-slave Oleksij Rempel
2020-06-10 8:37 ` [PATCH v4 1/3] update UAPI header copies Oleksij Rempel
2020-06-10 8:37 ` [PATCH v4 2/3] netlink: add master/slave configuration support Oleksij Rempel
2020-06-10 8:37 ` [PATCH v4 3/3] netlink: add LINKSTATE SQI support Oleksij Rempel
2020-06-10 20:05 ` Michal Kubecek [this message]
2020-06-12 13:10 ` [PATCH v4 0/3] Add support for SQI and master-slave Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610200535.zkozejqc3ssxpeam@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=amitc@mellanox.com \
--cc=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linville@tuxdriver.com \
--cc=marex@denx.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).