From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14610C433E0 for ; Wed, 10 Jun 2020 20:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8055206A4 for ; Wed, 10 Jun 2020 20:35:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="jErH93bS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbgFJUfq (ORCPT ); Wed, 10 Jun 2020 16:35:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726134AbgFJUfq (ORCPT ); Wed, 10 Jun 2020 16:35:46 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24155C03E96B for ; Wed, 10 Jun 2020 13:35:46 -0700 (PDT) Received: from zn.tnic (p200300ec2f0c19007c73a090adc89193.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:1900:7c73:a090:adc8:9193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 49E3C1EC02AC; Wed, 10 Jun 2020 22:35:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1591821344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=V0ulm0L6ba0Bx/c3Wx03Auva+CuUvMkvz9rzbSZmOtg=; b=jErH93bSYG7vueCYwcFnyBlQ/vfdS1WV5KxU+Ts7QABXjULkXakH7AOz8zPxtGBGgbL5KE oMRfNYAvKt58Ziq++7jORxfBJKjIjPcUGPmFNNWlA20TvMxFgPzLfHmSobeHfS0wl5oWzO e9iHioASB6Ghx2WA1flXVRFYMSYh+SM= Date: Wed, 10 Jun 2020 22:35:37 +0200 From: Borislav Petkov To: Kyung Min Park Cc: x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, gregkh@linuxfoundation.org, ak@linux.intel.com, dave.hansen@intel.com, tony.luck@intel.com, ravi.v.shankar@intel.com, ricardo.neri@intel.com Subject: Re: [RFC PATCH 0/3] Add Documentation for /proc/cpuinfo flags Message-ID: <20200610203537.GT14118@zn.tnic> References: <20200610200701.16757-1-kyung.min.park@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200610200701.16757-1-kyung.min.park@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 10, 2020 at 01:06:58PM -0700, Kyung Min Park wrote: > Include two instances of features for which there are not implemented > use cases in the kernel. > > Patch 1 creates a new documentation for /proc/cpuinfo flags bits. > Patch 2 adds X86_FEATURE_SERIALIZE. > Patch 3 adds X86_FEATURE_TSXLDTRK. > > This RFC series has been reviewed by Dave Hansen. Yeah, and he and I talked about this on IRC. If you really want to dump CPUID to see what's there, we should do a userspace tool in tools/ or even use the ones which are already out there: x86info, cpuid, ... Just adding X86_FEATURE_* flags without usage in the kernel makes no sense and will cause unnecessary bloat and doesn't help one bit because userspace simply calls CPUID directly. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette