From: Christian Brauner <christian.brauner@ubuntu.com>
To: Andrei Vagin <avagin@gmail.com>, Dmitry Safonov <dima@arista.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: vdso_join_timens() question
Date: Thu, 11 Jun 2020 13:02:21 +0200 [thread overview]
Message-ID: <20200611110221.pgd3r5qkjrjmfqa2@wittgenstein> (raw)
Hey,
I'm about to finish a patch to add CLONE_NEWTIME support to setns().
Since setns() now allows to attach to a multiple namespaces at the same
time I've also reworked it to be atomic (already upstream). Either all
namespaces are switched or no namespace is switched. All namespaces
basically now have a commit mode after which installation should ideally
not fail anymore. That could work for CLONE_NEWTIME too, I think. The
only blocker to this is vdso_join_timens() which can fail due to
mmap_write_lock_killable().
Is it possible to change this to mmap_write_lock()? So sm like:
diff --git a/arch/x86/entry/vdso/vma.c b/arch/x86/entry/vdso/vma.c
index ea7c1f0b79df..5c5b4cc61fce 100644
--- a/arch/x86/entry/vdso/vma.c
+++ b/arch/x86/entry/vdso/vma.c
@@ -144,8 +144,7 @@ int vdso_join_timens(struct task_struct *task, struct time_namespace *ns)
struct mm_struct *mm = task->mm;
struct vm_area_struct *vma;
- if (mmap_write_lock_killable(mm))
- return -EINTR;
+ mmap_write_lock(mm);
for (vma = mm->mmap; vma; vma = vma->vm_next) {
unsigned long size = vma->vm_end - vma->vm_start;
vdso_join_timens() is called in two places. Once during fork() and once
during timens_install(). I would only need the mmap_write_lock() change
for the latter. So alternatively we could have:
__vdso_join_timens_unlocked()
and then have/expose:
vdso_join_timens_fork()
{
if (mmap_write_lock_killable(mm))
return -EINTR;
__vdso_join_timens_unlocked()
mmap_write_unlock(mm);
}
and
vdso_join_timens_install()
{
mmap_write_lock(mm);
__vdso_join_timens_unlocked()
mmap_write_unlock(mm);
}
Thanks!
Christian
next reply other threads:[~2020-06-11 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 11:02 Christian Brauner [this message]
2020-06-11 19:17 ` vdso_join_timens() question Dmitry Safonov
2020-06-12 14:47 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611110221.pgd3r5qkjrjmfqa2@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=avagin@gmail.com \
--cc=dima@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).