* [PATCH] [v2] hwrng: ks-sa - Fix runtime PM imbalance on error
@ 2020-05-28 7:21 Dinghao Liu
2020-05-28 9:06 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2020-06-12 6:46 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Dinghao Liu @ 2020-05-28 7:21 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
Ben Dooks, YueHaibing, Kate Stewart, Alexander Sverdlin,
Thomas Gleixner, linux-crypto, linux-kernel
pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a pairing decrement is needed
on the error handling path to keep the counter balanced.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
Changelog:
v2: - Use pm_runtime_put_noidle() instead of pm_runtime_put_sync().
---
drivers/char/hw_random/ks-sa-rng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c
index e2330e757f1f..001617033d6a 100644
--- a/drivers/char/hw_random/ks-sa-rng.c
+++ b/drivers/char/hw_random/ks-sa-rng.c
@@ -244,6 +244,7 @@ static int ks_sa_rng_probe(struct platform_device *pdev)
ret = pm_runtime_get_sync(dev);
if (ret < 0) {
dev_err(dev, "Failed to enable SA power-domain\n");
+ pm_runtime_put_noidle(dev);
pm_runtime_disable(dev);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] hwrng: ks-sa - Fix runtime PM imbalance on error
2020-05-28 7:21 [PATCH] [v2] hwrng: ks-sa - Fix runtime PM imbalance on error Dinghao Liu
@ 2020-05-28 9:06 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2020-06-12 6:46 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Sverdlin, Alexander (Nokia - DE/Ulm) @ 2020-05-28 9:06 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: mpm, gregkh, herbert, ben.dooks, kstewart, arnd, tglx,
yuehaibing, linux-crypto, linux-kernel
Hello Dinghao,
On Thu, 2020-05-28 at 15:21 +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a pairing decrement is needed
> on the error handling path to keep the counter balanced.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
>
> Changelog:
>
> v2: - Use pm_runtime_put_noidle() instead of pm_runtime_put_sync().
> ---
> drivers/char/hw_random/ks-sa-rng.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c
> index e2330e757f1f..001617033d6a 100644
> --- a/drivers/char/hw_random/ks-sa-rng.c
> +++ b/drivers/char/hw_random/ks-sa-rng.c
> @@ -244,6 +244,7 @@ static int ks_sa_rng_probe(struct platform_device *pdev)
> ret = pm_runtime_get_sync(dev);
> if (ret < 0) {
> dev_err(dev, "Failed to enable SA power-domain\n");
> + pm_runtime_put_noidle(dev);
> pm_runtime_disable(dev);
> return ret;
> }
--
Alexander Sverdlin.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] hwrng: ks-sa - Fix runtime PM imbalance on error
2020-05-28 7:21 [PATCH] [v2] hwrng: ks-sa - Fix runtime PM imbalance on error Dinghao Liu
2020-05-28 9:06 ` Sverdlin, Alexander (Nokia - DE/Ulm)
@ 2020-06-12 6:46 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-06-12 6:46 UTC (permalink / raw)
To: Dinghao Liu
Cc: kjlu, Matt Mackall, Arnd Bergmann, Greg Kroah-Hartman, Ben Dooks,
YueHaibing, Kate Stewart, Alexander Sverdlin, Thomas Gleixner,
linux-crypto, linux-kernel
On Thu, May 28, 2020 at 03:21:04PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a pairing decrement is needed
> on the error handling path to keep the counter balanced.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
>
> Changelog:
>
> v2: - Use pm_runtime_put_noidle() instead of pm_runtime_put_sync().
> ---
> drivers/char/hw_random/ks-sa-rng.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-12 6:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 7:21 [PATCH] [v2] hwrng: ks-sa - Fix runtime PM imbalance on error Dinghao Liu
2020-05-28 9:06 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2020-06-12 6:46 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).