From: Christian Brauner <christian.brauner@ubuntu.com>
To: Kees Cook <keescook@chromium.org>
Cc: Shuah Khan <shuah@kernel.org>,
Christian Brauner <christian@brauner.io>,
linux-kselftest@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] selftests/clone3: Reorder reporting output
Date: Fri, 12 Jun 2020 20:19:40 +0200 [thread overview]
Message-ID: <20200612181940.njkyjixo55vawf2i@wittgenstein> (raw)
In-Reply-To: <20200611224028.3275174-2-keescook@chromium.org>
On Thu, Jun 11, 2020 at 03:40:22PM -0700, Kees Cook wrote:
> Selftest output reporting was happening before the TAP headers and plan
> had been emitted. Move the first test reports later.
>
> Cc: Christian Brauner <christian@brauner.io>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
Again, much appreciated:
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> tools/testing/selftests/clone3/clone3.c | 2 +-
> tools/testing/selftests/clone3/clone3_clear_sighand.c | 3 +--
> tools/testing/selftests/clone3/clone3_set_tid.c | 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c
> index f14c269a5a18..b7e6dec36173 100644
> --- a/tools/testing/selftests/clone3/clone3.c
> +++ b/tools/testing/selftests/clone3/clone3.c
> @@ -131,9 +131,9 @@ int main(int argc, char *argv[])
>
> uid_t uid = getuid();
>
> - test_clone3_supported();
> ksft_print_header();
> ksft_set_plan(17);
> + test_clone3_supported();
>
> /* Just a simple clone3() should return 0.*/
> test_clone3(0, 0, 0, CLONE3_ARGS_NO_TEST);
> diff --git a/tools/testing/selftests/clone3/clone3_clear_sighand.c b/tools/testing/selftests/clone3/clone3_clear_sighand.c
> index 9e1af8aa7698..db5fc9c5edcf 100644
> --- a/tools/testing/selftests/clone3/clone3_clear_sighand.c
> +++ b/tools/testing/selftests/clone3/clone3_clear_sighand.c
> @@ -119,9 +119,8 @@ static void test_clone3_clear_sighand(void)
> int main(int argc, char **argv)
> {
> ksft_print_header();
> - test_clone3_supported();
> -
> ksft_set_plan(1);
> + test_clone3_supported();
>
> test_clone3_clear_sighand();
>
> diff --git a/tools/testing/selftests/clone3/clone3_set_tid.c b/tools/testing/selftests/clone3/clone3_set_tid.c
> index 25beb22f35b5..5831c1082d6d 100644
> --- a/tools/testing/selftests/clone3/clone3_set_tid.c
> +++ b/tools/testing/selftests/clone3/clone3_set_tid.c
> @@ -157,8 +157,8 @@ int main(int argc, char *argv[])
> pid_t set_tid[MAX_PID_NS_LEVEL * 2];
>
> ksft_print_header();
> - test_clone3_supported();
> ksft_set_plan(29);
> + test_clone3_supported();
>
> if (pipe(pipe_1) < 0 || pipe(pipe_2) < 0)
> ksft_exit_fail_msg("pipe() failed\n");
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-06-12 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 22:40 [PATCH 0/7] selftests/harness: Switch to TAP output Kees Cook
2020-06-11 22:40 ` [PATCH 1/7] selftests/clone3: Reorder reporting output Kees Cook
2020-06-12 18:19 ` Christian Brauner [this message]
2020-06-11 22:40 ` [PATCH 2/7] selftests: Remove unneeded selftest API headers Kees Cook
2020-06-12 18:21 ` Christian Brauner
2020-06-11 22:40 ` [PATCH 3/7] selftests/binderfs: Fix harness API usage Kees Cook
2020-06-12 18:19 ` Christian Brauner
2020-06-12 18:41 ` Kees Cook
2020-06-11 22:40 ` [PATCH 4/7] selftests: Add header documentation and helpers Kees Cook
2020-06-11 22:40 ` [PATCH 5/7] selftests/harness: Switch to TAP output Kees Cook
2020-06-11 22:40 ` [PATCH 6/7] selftests/harness: Fully track XFAIL reports Kees Cook
2020-06-11 22:40 ` [PATCH 7/7] selftests/harness: Display signed values correctly Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612181940.njkyjixo55vawf2i@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=shuah@kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).