* [PATCH] clk: iproc: round clock rate to the closest
@ 2020-06-12 22:52 Ray Jui
2020-07-20 16:12 ` Ray Jui
2020-07-24 8:54 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Ray Jui @ 2020-06-12 22:52 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, bcm-kernel-feedback-list, Lori Hikichi, Ray Jui
From: Lori Hikichi <lhikichi@broadcom.com>
Change from 'DIV_ROUND_UP' to 'DIV_ROUND_CLOSEST' when calculating the
clock divisor in the iProc ASIU clock driver to allow to get to the
closest clock rate.
Fixes: 5fe225c105fd ("clk: iproc: add initial common clock support")
Signed-off-by: Lori Hikichi <lhikichi@broadcom.com>
Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
drivers/clk/bcm/clk-iproc-asiu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/bcm/clk-iproc-asiu.c b/drivers/clk/bcm/clk-iproc-asiu.c
index 6fb8af506777..e062dd4992ea 100644
--- a/drivers/clk/bcm/clk-iproc-asiu.c
+++ b/drivers/clk/bcm/clk-iproc-asiu.c
@@ -119,7 +119,7 @@ static long iproc_asiu_clk_round_rate(struct clk_hw *hw, unsigned long rate,
if (rate == *parent_rate)
return *parent_rate;
- div = DIV_ROUND_UP(*parent_rate, rate);
+ div = DIV_ROUND_CLOSEST(*parent_rate, rate);
if (div < 2)
return *parent_rate;
@@ -145,7 +145,7 @@ static int iproc_asiu_clk_set_rate(struct clk_hw *hw, unsigned long rate,
return 0;
}
- div = DIV_ROUND_UP(parent_rate, rate);
+ div = DIV_ROUND_CLOSEST(parent_rate, rate);
if (div < 2)
return -EINVAL;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: iproc: round clock rate to the closest
2020-06-12 22:52 [PATCH] clk: iproc: round clock rate to the closest Ray Jui
@ 2020-07-20 16:12 ` Ray Jui
2020-07-24 8:54 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Ray Jui @ 2020-07-20 16:12 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, bcm-kernel-feedback-list, Lori Hikichi
Hi Stephen/Michael,
Could you please help to review this patch?
Thanks,
Ray
On 6/12/2020 3:52 PM, Ray Jui wrote:
> From: Lori Hikichi <lhikichi@broadcom.com>
>
> Change from 'DIV_ROUND_UP' to 'DIV_ROUND_CLOSEST' when calculating the
> clock divisor in the iProc ASIU clock driver to allow to get to the
> closest clock rate.
>
> Fixes: 5fe225c105fd ("clk: iproc: add initial common clock support")
> Signed-off-by: Lori Hikichi <lhikichi@broadcom.com>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> ---
> drivers/clk/bcm/clk-iproc-asiu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/bcm/clk-iproc-asiu.c b/drivers/clk/bcm/clk-iproc-asiu.c
> index 6fb8af506777..e062dd4992ea 100644
> --- a/drivers/clk/bcm/clk-iproc-asiu.c
> +++ b/drivers/clk/bcm/clk-iproc-asiu.c
> @@ -119,7 +119,7 @@ static long iproc_asiu_clk_round_rate(struct clk_hw *hw, unsigned long rate,
> if (rate == *parent_rate)
> return *parent_rate;
>
> - div = DIV_ROUND_UP(*parent_rate, rate);
> + div = DIV_ROUND_CLOSEST(*parent_rate, rate);
> if (div < 2)
> return *parent_rate;
>
> @@ -145,7 +145,7 @@ static int iproc_asiu_clk_set_rate(struct clk_hw *hw, unsigned long rate,
> return 0;
> }
>
> - div = DIV_ROUND_UP(parent_rate, rate);
> + div = DIV_ROUND_CLOSEST(parent_rate, rate);
> if (div < 2)
> return -EINVAL;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: iproc: round clock rate to the closest
2020-06-12 22:52 [PATCH] clk: iproc: round clock rate to the closest Ray Jui
2020-07-20 16:12 ` Ray Jui
@ 2020-07-24 8:54 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-07-24 8:54 UTC (permalink / raw)
To: Michael Turquette, Ray Jui
Cc: linux-clk, linux-kernel, bcm-kernel-feedback-list, Lori Hikichi, Ray Jui
Quoting Ray Jui (2020-06-12 15:52:12)
> From: Lori Hikichi <lhikichi@broadcom.com>
>
> Change from 'DIV_ROUND_UP' to 'DIV_ROUND_CLOSEST' when calculating the
> clock divisor in the iProc ASIU clock driver to allow to get to the
> closest clock rate.
>
> Fixes: 5fe225c105fd ("clk: iproc: add initial common clock support")
> Signed-off-by: Lori Hikichi <lhikichi@broadcom.com>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-24 8:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 22:52 [PATCH] clk: iproc: round clock rate to the closest Ray Jui
2020-07-20 16:12 ` Ray Jui
2020-07-24 8:54 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).