From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C3BC433E0 for ; Mon, 15 Jun 2020 20:31:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F37E0208D5 for ; Mon, 15 Jun 2020 20:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731553AbgFOUbm (ORCPT ); Mon, 15 Jun 2020 16:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731529AbgFOUbi (ORCPT ); Mon, 15 Jun 2020 16:31:38 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19B6CC061A0E; Mon, 15 Jun 2020 13:31:38 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4A520120ED49A; Mon, 15 Jun 2020 13:31:37 -0700 (PDT) Date: Mon, 15 Jun 2020 13:31:36 -0700 (PDT) Message-Id: <20200615.133136.632752213609052484.davem@davemloft.net> To: brgl@bgdev.pl Cc: john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, kuba@kernel.org, matthias.bgg@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, fparent@baylibre.com, stephane.leprovost@mediatek.com, pedro.tsai@mediatek.com, andrew.perepech@mediatek.com, bgolaszewski@baylibre.com Subject: Re: [PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling From: David Miller In-Reply-To: <20200611140139.17702-1-brgl@bgdev.pl> References: <20200611140139.17702-1-brgl@bgdev.pl> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jun 2020 13:31:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Date: Thu, 11 Jun 2020 16:01:39 +0200 > From: Bartosz Golaszewski > > During development we tried to make the interrupt handling as fine-grained > as possible with TX and RX interrupts being disabled/enabled independently > and the counter registers reset from workqueue context. > > Unfortunately after thorough testing of current mainline, we noticed the > driver has become unstable under heavy load. While this is hard to > reproduce, it's quite consistent in the driver's current form. > > This patch proposes to go back to the previous approach of doing all > processing in napi context with all interrupts masked in order to make the > driver usable in mainline linux. This doesn't impact the performance on > pumpkin boards at all and it's in line with what many ethernet drivers do > in mainline linux anyway. > > At the same time we're adding a FIXME comment about the need to improve > the interrupt handling. > > Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") > Signed-off-by: Bartosz Golaszewski Applied.