From: Maxime Ripard <maxime@cerno.tech>
To: Diego Rondini <diego.rondini@kynetics.com>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/2] ARM: dts: orange-pi-zero-plus2: add leds configuration
Date: Mon, 15 Jun 2020 10:14:31 +0200 [thread overview]
Message-ID: <20200615081431.sbqezly4jcryvxk6@gilmour.lan> (raw)
In-Reply-To: <20200528204712.552964-2-diego.rondini@kynetics.com>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
On Thu, May 28, 2020 at 10:47:12PM +0200, Diego Rondini wrote:
> Add pwr and status leds configuration and turn on pwr led by default for Orange
> Pi Zero Plus 2 (both H3 and H5 variants).
>
> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
> ---
> .../boot/dts/sun8i-h3-orangepi-zero-plus2.dts | 16 ++++++++++++++++
> .../allwinner/sun50i-h5-orangepi-zero-plus2.dts | 16 ++++++++++++++++
> 2 files changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts
> index 4376767699a47..4cd0ac706bd2c 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts
> @@ -82,6 +82,22 @@ wifi_pwrseq: wifi_pwrseq {
> reset-gpios = <&pio 0 9 GPIO_ACTIVE_LOW>; /* PA9 */
> post-power-on-delay-ms = <200>;
> };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + pwr_led {
> + label = "orangepi:green:pwr";
> + gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>;
> + default-state = "on";
> + };
> +
> + status_led {
Having an underscore in the node name will trigger a DTC warning. What
about using pwr and status as nodenames?
> + label = "orangepi:red:status";
> + gpios = <&pio 0 17 GPIO_ACTIVE_HIGH>;
> + };
> +
There's an extra line here that you should remove
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-06-15 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 20:47 [PATCH 1/2] ARM: dts: orange-pi-zero-plus2: enable USB OTG port Diego Rondini
2020-05-28 20:47 ` [PATCH 2/2] ARM: dts: orange-pi-zero-plus2: add leds configuration Diego Rondini
2020-06-15 8:14 ` Maxime Ripard [this message]
2020-06-15 8:12 ` [PATCH 1/2] ARM: dts: orange-pi-zero-plus2: enable USB OTG port Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615081431.sbqezly4jcryvxk6@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=diego.rondini@kynetics.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).