From: Dominique Martinet <asmadeus@codewreck.org>
To: Zheng Bin <zhengbin13@huawei.com>
Cc: ericvh@gmail.com, lucho@ionkov.net,
v9fs-developer@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH RESEND] 9p: Fix memory leak in v9fs_mount
Date: Mon, 15 Jun 2020 12:20:53 +0200 [thread overview]
Message-ID: <20200615102053.GA11026@nautica> (raw)
In-Reply-To: <20200615012153.89538-1-zhengbin13@huawei.com>
Zheng Bin wrote on Mon, Jun 15, 2020:
> v9fs_mount
> v9fs_session_init
> v9fs_cache_session_get_cookie
> v9fs_random_cachetag -->alloc cachetag
> v9ses->fscache = fscache_acquire_cookie -->maybe NULL
> sb = sget -->fail, goto clunk
> clunk_fid:
> v9fs_session_close
> if (v9ses->fscache) -->NULL
> kfree(v9ses->cachetag)
>
> Thus memleak happens.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Thanks, will run tests & queue next weekend
--
Dominique
next prev parent reply other threads:[~2020-06-15 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 1:21 [PATCH RESEND] 9p: Fix memory leak in v9fs_mount Zheng Bin
2020-06-15 10:20 ` Dominique Martinet [this message]
2020-07-09 2:04 ` Zhengbin (OSKernel)
2020-07-10 11:05 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615102053.GA11026@nautica \
--to=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=yi.zhang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).