From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76389C433DF for ; Mon, 15 Jun 2020 12:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56CEC20663 for ; Mon, 15 Jun 2020 12:45:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="R5Vktszu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730015AbgFOMpO (ORCPT ); Mon, 15 Jun 2020 08:45:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729989AbgFOMpL (ORCPT ); Mon, 15 Jun 2020 08:45:11 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46ACFC05BD1E for ; Mon, 15 Jun 2020 05:45:11 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o8so5061180wmh.4 for ; Mon, 15 Jun 2020 05:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5WfldrA7Ybz/CNtCQsbY2j9hmaVRS/lefK2C8B4/ydo=; b=R5VktszuPwRyfKbFUb+M5pY4vbiXCrk4+CjaMUdUvbr7PL1EAycwk6hGg4WlqYqmSY i46OfPU4CdegDGwNZ89JPs5mBGxAqhTNbEV7Eqxql4wv+MFbyHcmJURiBnibI5m9o+Mz 95M+LPZV7RdAvnGdDKofnOZsLb4NljOrjzxghwOXeVYOwW1P3B2O7lly8VxrGBEin/5M 634k7g8/GeaLN9NVEhvjgSLc/+Rv/LlOHfmPtwECdnW8JBSagOi3A4sT3GVVXvf0dhaf 8WyQqLaEYjxztW7LztMm4qjwAeRjtZoyLIeaw6Fi4uh8tljKNIEpNLRIzQDaD7qBNE/j E3bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5WfldrA7Ybz/CNtCQsbY2j9hmaVRS/lefK2C8B4/ydo=; b=mEOl77+234hjga+5gfbFr9FzxLLH+CYZm76pA0ljKFSnWZoSoqTlx1Bxd02VbGr/ag zTd2TwBc6tVRKr9KmzKbMUNYUiXeQJ62HOdj2nU/Xj82roSC18R1Ke7iD21J+bWEtXuU gDrn6GnuXcMVcqhfvBl7W+2yDvvYbpu8sJZgREldoc52DLIXX4hbu9hFJG1IQr8jAiUW qFYaKDzz7u3JB3fyd6aBI36Wu+2g6o+O0lVkjFnRWdd/Ca+9WoFc0nEsHKmpxWCWxJDg 0gsYbntY9lTpgqFoGYMBNavlToGwKrDihv3A5Af1TaL6sJDLCeeS796vnANhrBYPS3gl uw2g== X-Gm-Message-State: AOAM530NdLSkk9qQnpJptij5fXSh59Ya2jf3iaf/yB84tBkJdJbR2EjB KfAI1EElBBhi7VTWhglGK41xyDhebReJPQ== X-Google-Smtp-Source: ABdhPJyOUgN6W95sji6BAD0z9Le4kY3qbFFlPrhTK7NksEopHHTFOHCgqndp2ELuG3T5LFhG8TYLWQ== X-Received: by 2002:a1c:188:: with SMTP id 130mr13072660wmb.93.1592225109747; Mon, 15 Jun 2020 05:45:09 -0700 (PDT) Received: from x1 (i59F66838.versanet.de. [89.246.104.56]) by smtp.gmail.com with ESMTPSA id c16sm24705585wrx.4.2020.06.15.05.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 05:45:09 -0700 (PDT) Date: Mon, 15 Jun 2020 14:45:06 +0200 From: Drew Fustini To: Grygorii Strashko Cc: Tony Lindgren , Rob Herring , Linux-OMAP , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Kridner , Robert Nelson , Vinod Koul Subject: Re: [PATCH] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode Message-ID: <20200615124506.GA3833448@x1> References: <20200611220951.GA3355634@x1> <10637da2-8751-3c6f-cf1e-f0a53cca292d@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10637da2-8751-3c6f-cf1e-f0a53cca292d@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2020 at 12:34:57PM +0300, Grygorii Strashko wrote: > > > On 12/06/2020 01:09, Drew Fustini wrote: > > Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for > > RGMII mode") the networking is broken on the BeagleBone AI which has > > the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from > > phy-mode = "rgmii" to phy-mode = "rgmii-rxid". > > > > Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for > > other AM5729 boards. > > commit ref is incorrect Do you mean commit ref 820f8a870f65 ? ("ARM: dts: am57xx: fix networking on boards with ksz9031 phy") I thought it made sense to point to that commit as you seemed to be fixing a very similar issue, just for a different phy. Or did you mean commit ref cd28d1d6e52e ? ("net: phy: at803x: Disable phy delay for RGMII mode") I believe this is the commit that made it necessary to change the phy-mode property for the AR8035 PHY. > > > > [0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf > > > > Cc: Vinod Koul > > Cc: Grygorii Strashko > > Fixes: cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") > > Pls change fixed tag to > 520557d4854b ARM: dts: am5729: beaglebone-ai: adding device tree > as this board DTB was merged only in 5.8. Ok, will do. > > > Signed-off-by: Robert Nelson > > Signed-off-by: Drew Fustini > > --- > > arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts > > index 9877d7709d41..4c51c6b05e64 100644 > > --- a/arch/arm/boot/dts/am5729-beagleboneai.dts > > +++ b/arch/arm/boot/dts/am5729-beagleboneai.dts > > @@ -505,7 +505,7 @@ &mac { > > &cpsw_emac0 { > > phy-handle = <&phy0>; > > - phy-mode = "rgmii"; > > + phy-mode = "rgmii-rxid"; > > }; > > &ocp { > > > > Thanks, pls fix above and you can add my > Reviewed-by: Grygorii Strashko > > -- > Best regards, > grygorii Thanks for taking the time to review. -Drew