From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57572C433DF for ; Mon, 15 Jun 2020 13:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 382B4207D3 for ; Mon, 15 Jun 2020 13:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592228492; bh=5yU8kGdPOUzUeaSLJ4oZ8Z8E8amDtVLdFsG4wItH9+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=cT/+/w0Soc3ukA86oKWKyb5ZyULO1EBZgAARGOK/jBIuBM8XQly9RIL5/mvewQSk7 Ta9st9+dv5WkK77nNIssKSUuTn4R77UVzrwGZm7yohyHZMZn5TF2hTKtuE1Gb278W+ xk7L4ccyGZmJPQpWzFa4+2wOH3nZh/KAcCmurIWA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730528AbgFONl3 (ORCPT ); Mon, 15 Jun 2020 09:41:29 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:39964 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730144AbgFONl1 (ORCPT ); Mon, 15 Jun 2020 09:41:27 -0400 Received: by mail-wr1-f67.google.com with SMTP id h5so17211889wrc.7; Mon, 15 Jun 2020 06:41:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ldZ3qHesEPGPxRDy2PP+eNgQCVg0OujHEQewstkBEeU=; b=jA5k23mlbwIzkQE4LMtlQnpaoBh53mSiTfiId1dOw8Mf2cErvL1nzI+UjNswKEwgO6 FPV4SF85jTtX3Cl31PQz++97s2ouDRvaGms2ThOWd5DBG4baTMwDrsk/oVkjpddxLyth npGk2RY+ieASVplZEd0bTOx91lUDX/xvlmJqOSYFD9iZXuXs7pssjnhI80lWkJ0d0Eky E7ZlnXxy1jpy4XhZ6Nv4cFzWdZAStzxBD1tLDgUU1GT95hdXMFFeBOIbeXp0dSk243W4 i+fty3zoSFWv/7JDB0vtlcLIlX2LUFFknQgXw8KUQ311LADnL6rcV3//idIk9zD+tDyp xeRw== X-Gm-Message-State: AOAM531lBy6rLnL+wEUfwVqa5MvRtTsvB8uOWaYuwyI7ZDL0azv9+MMG tmef1QIui/lAPZgdo+q3MFk= X-Google-Smtp-Source: ABdhPJxEQoPl9fMwozzagAz4U4ysT/MZSAaF26yHkz0oVX6eTwy/fgnKn3eGxjmHAf/0JWCAxrTRGw== X-Received: by 2002:adf:9205:: with SMTP id 5mr27655753wrj.232.1592228485925; Mon, 15 Jun 2020 06:41:25 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id 104sm25964040wrl.25.2020.06.15.06.41.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jun 2020 06:41:25 -0700 (PDT) Date: Mon, 15 Jun 2020 15:41:19 +0200 From: Krzysztof Kozlowski To: Vladimir Oltean Cc: Mark Brown , Marc Kleine-Budde , Thomas Gleixner , Vladimir Oltean , linux-spi , lkml , Wolfram Sang , stable@vger.kernel.org, Pengutronix Kernel Team Subject: Re: [PATCH v2 1/3] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths Message-ID: <20200615134119.GB3321@kozik-lap> References: <1592208439-17594-1-git-send-email-krzk@kernel.org> <20200615123052.GO4447@sirena.org.uk> <20200615131006.GR4447@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2020 at 04:12:28PM +0300, Vladimir Oltean wrote: > On Mon, 15 Jun 2020 at 16:10, Mark Brown wrote: > > > > > It's a bit unusual to need to actually free the IRQ over suspend - > > what's driving that requirement here? > > clk_disable_unprepare(dspi->clk); is driving the requirement - same as > in dspi_remove case, the module will fault when its registers are > accessed without a clock. In few cases when I have shared interrupt in different drivers, they were just disabling it during suspend. Why it has to be freed? Best regards, Krzysztof