From: Al Viro <viro@zeniv.linux.org.uk>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Sagi Grimberg <sagi@lightbitslabs.com>,
Christoph Hellwig <hch@lst.de>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [v3 PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h
Date: Mon, 15 Jun 2020 15:16:47 +0100 [thread overview]
Message-ID: <20200615141647.GK23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200612065737.GA17176@gondor.apana.org.au>
On Fri, Jun 12, 2020 at 04:57:37PM +1000, Herbert Xu wrote:
> The header file linux/uio.h includes crypto/hash.h which pulls in
> most of the Crypto API. Since linux/uio.h is used throughout the
> kernel this means that every tiny bit of change to the Crypto API
> causes the entire kernel to get rebuilt.
>
> This patch fixes this by moving it into lib/iov_iter.c instead
> where it is actually used.
>
> This patch also fixes the ifdef to use CRYPTO_HASH instead of just
> CRYPTO which does not guarantee the existence of ahash.
>
> Unfortunately a number of drivers were relying on linux/uio.h to
> provide access to linux/slab.h. This patch adds inclusions of
> linux/slab.h as detected by build failures.
>
> Also skbuff.h was relying on this to provide a declaration for
> ahash_request. This patch adds a forward declaration instead.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied; let it sit in -next for a while to get better build coverage...
prev parent reply other threads:[~2020-06-15 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 7:43 [PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h Herbert Xu
2020-06-11 7:56 ` Herbert Xu
2020-06-11 10:48 ` kernel test robot
2020-06-11 10:51 ` kernel test robot
2020-06-11 10:51 ` kernel test robot
2020-06-11 10:53 ` kernel test robot
2020-06-11 11:49 ` [v2 PATCH] " Herbert Xu
2020-06-12 6:57 ` [v3 " Herbert Xu
2020-06-15 7:09 ` Christoph Hellwig
2020-06-15 14:16 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615141647.GK23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sagi@lightbitslabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).