From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
Guru Das Srinagesh <gurus@codeaurora.org>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] video: ssd1307fb: Print PWM period using 64-bit format specifier
Date: Mon, 15 Jun 2020 17:18:16 +0200 [thread overview]
Message-ID: <20200615151816.wrhqwffvw3h436ar@taurus.defre.kleine-koenig.org> (raw)
In-Reply-To: <20200615141606.2814208-2-thierry.reding@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]
Hello,
On Mon, Jun 15, 2020 at 04:16:05PM +0200, Thierry Reding wrote:
> The PWM core will soon change the duty cycle and period of PWMs to 64
> bits to allow for a broader range of values. Use a 64-bit format
> specifier to avoid a warning when that change is made.
>
> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
> ---
> drivers/video/fbdev/ssd1307fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 8e06ba912d60..09425ec317ba 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -312,7 +312,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
> /* Enable the PWM */
> pwm_enable(par->pwm);
>
> - dev_dbg(&par->client->dev, "Using PWM%d with a %dns period.\n",
> + dev_dbg(&par->client->dev, "Using PWM%d with a %lluns period.\n",
> par->pwm->pwm, pwm_get_period(par->pwm));
I wonder a bit about the driver accessing par->pwm->pwm, but that's
orthogonal to this patch.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-15 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 14:16 [PATCH 0/2] pwm: Miscellaneous fixes for 64-bit support Thierry Reding
2020-06-15 14:16 ` [PATCH 1/2] video: ssd1307fb: Print PWM period using 64-bit format specifier Thierry Reding
2020-06-15 15:18 ` Uwe Kleine-König [this message]
2020-06-15 17:19 ` kernel test robot
2020-06-15 17:25 ` kernel test robot
2020-06-17 7:18 ` Geert Uytterhoeven
2020-06-17 17:30 ` Uwe Kleine-König
2020-06-18 20:05 ` Guru Das Srinagesh
2020-06-19 6:46 ` Geert Uytterhoeven
2020-06-15 14:16 ` [PATCH 2/2] pwm: iqs620a: Use 64-bit division Thierry Reding
2020-06-15 15:16 ` Uwe Kleine-König
2020-06-16 7:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615151816.wrhqwffvw3h436ar@taurus.defre.kleine-koenig.org \
--to=u.kleine-koenig@pengutronix.de \
--cc=b.zolnierkie@samsung.com \
--cc=gurus@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).