From: Rob Herring <robh@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: aisheng.dong@nxp.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux@rempel-privat.de,
wolfram@the-dreams.de, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH V2 2/3] dt-bindings: i2c: Convert mxs i2c to json-schema
Date: Mon, 15 Jun 2020 11:06:13 -0600 [thread overview]
Message-ID: <20200615170613.GA1959567@bogus> (raw)
In-Reply-To: <1591235358-15516-3-git-send-email-Anson.Huang@nxp.com>
On Thu, Jun 04, 2020 at 09:49:17AM +0800, Anson Huang wrote:
> Convert the MXS I2C binding to DT schema format using json-schema
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - add "additionalProperties: false".
> ---
> Documentation/devicetree/bindings/i2c/i2c-mxs.txt | 25 ----------
> Documentation/devicetree/bindings/i2c/i2c-mxs.yaml | 55 ++++++++++++++++++++++
> 2 files changed, 55 insertions(+), 25 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mxs.yaml
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mxs.txt b/Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> deleted file mode 100644
> index 4e1c8ac..0000000
> --- a/Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -* Freescale MXS Inter IC (I2C) Controller
> -
> -Required properties:
> -- compatible: Should be "fsl,<chip>-i2c"
> -- reg: Should contain registers location and length
> -- interrupts: Should contain ERROR interrupt number
> -- clock-frequency: Desired I2C bus clock frequency in Hz.
> - Only 100000Hz and 400000Hz modes are supported.
> -- dmas: DMA specifier, consisting of a phandle to DMA controller node
> - and I2C DMA channel ID.
> - Refer to dma.txt and fsl-mxs-dma.txt for details.
> -- dma-names: Must be "rx-tx".
> -
> -Examples:
> -
> -i2c0: i2c@80058000 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - compatible = "fsl,imx28-i2c";
> - reg = <0x80058000 2000>;
> - interrupts = <111>;
> - clock-frequency = <100000>;
> - dmas = <&dma_apbx 6>;
> - dma-names = "rx-tx";
> -};
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml b/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml
> new file mode 100644
> index 0000000..3bc14bb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/i2c-mxs.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MXS Inter IC (I2C) Controller
> +
> +maintainers:
> + - Shawn Guo <shawn.guo@linaro.org>
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,imx23-i2c
> + - fsl,imx28-i2c
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clock-frequency:
> + $ref: /schemas/types.yaml#/definitions/uint32
'clock-frequency' already has a type.
> + description: |
> + Desired I2C bus clock frequency in Hz, only 100000Hz and 400000Hz
> + modes are supported.
Sounds like constraints.
> + default: 100000
> +
> + dmas:
> + maxItems: 1
> +
> + dma-names:
> + const: rx-tx
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - dmas
> + - dma-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c@80058000 {
> + compatible = "fsl,imx28-i2c";
> + reg = <0x80058000 2000>;
> + interrupts = <111>;
> + clock-frequency = <100000>;
> + dmas = <&dma_apbx 6>;
> + dma-names = "rx-tx";
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-06-15 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 1:49 [PATCH V2 0/3] Convert i.MX/MXS I2C/LPI2C binding doc to json-schema Anson Huang
2020-06-04 1:49 ` [PATCH V2 1/3] dt-bindings: i2c: Convert imx lpi2c " Anson Huang
2020-06-15 17:05 ` Rob Herring
2020-06-04 1:49 ` [PATCH V2 2/3] dt-bindings: i2c: Convert mxs i2c " Anson Huang
2020-06-15 17:06 ` Rob Herring [this message]
2020-06-04 1:49 ` [PATCH V2 3/3] dt-bindings: i2c: Convert imx " Anson Huang
2020-06-15 17:10 ` Rob Herring
2020-06-16 3:58 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615170613.GA1959567@bogus \
--to=robh@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wolfram@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).