From: Rob Herring <robh@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v6 1/4] dt-bindings: net: Add tx and rx internal delays
Date: Mon, 15 Jun 2020 11:33:36 -0600 [thread overview]
Message-ID: <20200615173336.GA2002437@bogus> (raw)
In-Reply-To: <20200604111410.17918-2-dmurphy@ti.com>
On Thu, Jun 04, 2020 at 06:14:07AM -0500, Dan Murphy wrote:
> tx-internal-delays and rx-internal-delays are a common setting for RGMII
> capable devices.
>
> These properties are used when the phy-mode or phy-controller is set to
> rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the
> controller that the PHY will add the internal delay for the connection.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> .../devicetree/bindings/net/ethernet-phy.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> index 9b1f1147ca36..edd0245d132b 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> @@ -162,6 +162,19 @@ properties:
> description:
> Specifies a reference to a node representing a SFP cage.
>
> +
> + rx-internal-delay-ps:
> + $ref: /schemas/types.yaml#definitions/uint32
Standard units already have a type, so you can drop this.
> + description: |
> + RGMII Receive PHY Clock Delay defined in pico seconds. This is used for
> + PHY's that have configurable RX internal delays.
> +
> + tx-internal-delay-ps:
> + $ref: /schemas/types.yaml#definitions/uint32
> + description: |
> + RGMII Transmit PHY Clock Delay defined in pico seconds. This is used for
> + PHY's that have configurable TX internal delays.
> +
> required:
> - reg
>
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-06-15 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 11:14 [PATCH net-next v6 0/4] RGMII Internal delay common property Dan Murphy
2020-06-04 11:14 ` [PATCH net-next v6 1/4] dt-bindings: net: Add tx and rx internal delays Dan Murphy
2020-06-15 17:33 ` Rob Herring [this message]
2020-06-04 11:14 ` [PATCH net-next v6 2/4] net: phy: Add a helper to return the index for of the internal delay Dan Murphy
2020-06-04 11:14 ` [PATCH net-next v6 3/4] dt-bindings: net: Add RGMII internal delay for DP83869 Dan Murphy
2020-06-15 17:34 ` Rob Herring
2020-06-04 11:14 ` [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration Dan Murphy
2020-06-04 16:25 ` Jakub Kicinski
2020-06-04 16:38 ` Dan Murphy
2020-06-04 16:48 ` Jakub Kicinski
2020-06-04 20:27 ` Dan Murphy
2020-06-04 21:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615173336.GA2002437@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).