From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06284C433E1 for ; Mon, 15 Jun 2020 22:42:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E46F3207D4 for ; Mon, 15 Jun 2020 22:42:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726543AbgFOWmV (ORCPT ); Mon, 15 Jun 2020 18:42:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:55808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbgFOWmV (ORCPT ); Mon, 15 Jun 2020 18:42:21 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A8E52074D; Mon, 15 Jun 2020 22:42:20 +0000 (UTC) Date: Mon, 15 Jun 2020 18:42:18 -0400 From: Steven Rostedt To: Randy Dunlap Cc: Joe Perches , Masami Hiramatsu , stable@vger.kernel.org, LKML Subject: Re: [PATCH 1/4] proc/bootconfig: Fix to use correct quotes for value Message-ID: <20200615184218.752a17fa@oasis.local.home> In-Reply-To: References: <159197538852.80267.10091816844311950396.stgit@devnote2> <159197539793.80267.10836787284189465765.stgit@devnote2> <20200615151139.5cc223fc@oasis.local.home> <7abefbc81fc6aaefed6bbd2117e7bc97b90babe9.camel@perches.com> <20200615172123.1fe77f3c@oasis.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Jun 2020 15:30:41 -0700 Randy Dunlap wrote: > >> Please don't infect kernel sources with that style oddity. > > > > What do you mean? It's already "infected" all over the kernel, (has > > been for years!) and I kinda like it. It makes reading variables much > > easier on the eyes, and as I get older, that means a lot more ;-) > > Yeah, there is some infection, more in some places than others, > but I agree with Joe -- it's not needed or wanted by some of us. We all have preferences. But for code that I need to review, I prefer it. Why would you be bothered by it? Which is easier on the eyes to read variables? struct xbc_node *leaf, *vnode; const char *val; char q; char *key, *end = dst + size; int ret = 0; or struct xbc_node *leaf, *vnode; char *key, *end = dst + size; const char *val; char q; int ret = 0; ? -- Steve