From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF626C433DF for ; Mon, 15 Jun 2020 19:26:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95FC0207D3 for ; Mon, 15 Jun 2020 19:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592249196; bh=AvkDF1W+evs4ACyDeBmJZSphxtaBgYojELjru6qP34U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=N8GvfG0gncLKr8jm5egHbWxr31lMp4XcymrGQPCZ8ltggKgk99c7tEXYfGBXlghms lZ6hciiTw1AMaytMYD6rCP0AMsGoafoBIZFhRcge1zXcvY6VL9tzOiLKZ4pc0NnHAb WmpmG3ODMn//3kqtd7CQD9EC3zSZAn6cUOr2sXQI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730017AbgFOT0f (ORCPT ); Mon, 15 Jun 2020 15:26:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:49064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729854AbgFOT0d (ORCPT ); Mon, 15 Jun 2020 15:26:33 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0B9420756; Mon, 15 Jun 2020 19:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592249193; bh=AvkDF1W+evs4ACyDeBmJZSphxtaBgYojELjru6qP34U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AL6Ge9s0gex0hxoxM3nzvCoe5DV/SPRIHO8CUoZbbay9M628GxRDagsRytBs1A9hF IsifoHGmtCVGfPlnC3zKNzsG6zYkedW5VzfUXPM9n6gdKYZVYEA+h/q2CB3/L5Qk9H XMKdQOOeOQeTwF6cws0Y/DjmJP/RimvZu81zBaXI= Date: Mon, 15 Jun 2020 20:26:30 +0100 From: Mark Brown To: Robin Murphy Cc: Florian Fainelli , lukas@wunner.de, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, "open list:SPI SUBSYSTEM" , Rob Herring , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Martin Sperl , Nicolas Saenz Julienne Subject: Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support Message-ID: <20200615192630.GC4447@sirena.org.uk> References: <20200605132037.GF5413@sirena.org.uk> <2e371a32-fb52-03a2-82e4-5733d9f139cc@arm.com> <06342e88-e130-ad7a-9f97-94f09156f868@arm.com> <20200608112840.GC4593@sirena.org.uk> <20200615170031.GA4447@sirena.org.uk> <692bc94e-d574-e07a-d834-c0d569e87bba@gmail.com> <2f354ed0-9fb7-59ea-ddd1-78703d9c818e@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dOtxUVmLoGkyu1PA" Content-Disposition: inline In-Reply-To: <2f354ed0-9fb7-59ea-ddd1-78703d9c818e@arm.com> X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dOtxUVmLoGkyu1PA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 15, 2020 at 06:31:58PM +0100, Robin Murphy wrote: > Now that I've been inclined to go and look up the documentation, are we sure > this so-very-contentious check is even correct? From my reading of things > we're checking whether the RXR interrupt function is *enabled*, which still > says nothing about whether either condition for the interrupt being > *asserted* is true (RXR = 1 or DONE = 1). Thus if more than one SPI instance > is active at once we could still end up trying to service an IRQ on a > controller that didn't raise it. OK, I've pulled the patch from the queue for now :/ --dOtxUVmLoGkyu1PA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7ny2YACgkQJNaLcl1U h9Dlcwf/TI9wOgBtOFPjlWSb4Y2ZgnY4A2yEniFWHZl5+Z/hDkPg8DQB5gpHbOJB aq6nJ/zdl7Ls8/2fAZFBLoKdl1x02xn0g50XxakTsSSVgaumCRRjx/bZkpnWDRMi hOv3B7MZ/8QIJaoW4XW9h4Gr+FUmYL7OGkVcE0ZfPkN+raFcKBhRC6J3CZODGONN xa7O7JtoQu8TFEnp97ymMxfxpWdiyGRfkz0eCJMiFLjv+1CUcneJEMDJ+RRZzQbZ /KAoGLuKCfm0fFD5QlI9XwsSEVpPa0BHmSWbGa+cxxRZMqq0EnmYzL4TT9twKHXi QK/ulZP2pSHvw+ZBQfDln2Mm1nPbhQ== =3Gjc -----END PGP SIGNATURE----- --dOtxUVmLoGkyu1PA--