linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override
@ 2020-06-15 20:49 Federico Ricchiuto
  2020-06-16 11:30 ` Hans de Goede
  0 siblings, 1 reply; 6+ messages in thread
From: Federico Ricchiuto @ 2020-06-15 20:49 UTC (permalink / raw)
  To: jikos
  Cc: Federico Ricchiuto, Jiri Kosina, Benjamin Tissoires,
	Hans de Goede, Kai-Heng Feng, linux-input, linux-kernel

The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does
not supply descriptors, so it has to be added to the override list.

Signed-off-by: Federico Ricchiuto <fed.ricchiuto@gmail.com>
---
 drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
index a66f08041a1a..bb3f802935cc 100644
--- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
+++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
@@ -373,6 +373,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = {
 		},
 		.driver_data = (void *)&sipodev_desc
 	},
+	{
+		.ident = "Mediacom FlexBook edge 13",
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MEDIACOM"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FlexBook_edge13-M-FBE13"),
+		},
+		.driver_data = (void *)&sipodev_desc
+	},
 	{
 		.ident = "Odys Winbook 13",
 		.matches = {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override
  2020-06-15 20:49 [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override Federico Ricchiuto
@ 2020-06-16 11:30 ` Hans de Goede
  2020-06-16 15:19   ` Jiri Kosina
  0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2020-06-16 11:30 UTC (permalink / raw)
  To: Federico Ricchiuto, jikos
  Cc: Jiri Kosina, Benjamin Tissoires, Kai-Heng Feng, linux-input,
	linux-kernel

Hi,

On 6/15/20 10:49 PM, Federico Ricchiuto wrote:
> The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does
> not supply descriptors, so it has to be added to the override list.
> 
> Signed-off-by: Federico Ricchiuto <fed.ricchiuto@gmail.com>

It looks like you copied and pasted part of the commit message from
another patch (which is fine), but you need to update the Subject
(the first line of the commit message) the Subject now still
mentions the Trekstor Surfbook E11B rather then the
Mediacom FlexBook edge13.

Otherwise this looks good to me.

Regards,

Hans


> ---
>   drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> index a66f08041a1a..bb3f802935cc 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> @@ -373,6 +373,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = {
>   		},
>   		.driver_data = (void *)&sipodev_desc
>   	},
> +	{
> +		.ident = "Mediacom FlexBook edge 13",
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MEDIACOM"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FlexBook_edge13-M-FBE13"),
> +		},
> +		.driver_data = (void *)&sipodev_desc
> +	},
>   	{
>   		.ident = "Odys Winbook 13",
>   		.matches = {
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override
  2020-06-16 11:30 ` Hans de Goede
@ 2020-06-16 15:19   ` Jiri Kosina
  0 siblings, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2020-06-16 15:19 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Federico Ricchiuto, jikos, Benjamin Tissoires, Kai-Heng Feng,
	linux-input, linux-kernel

On Tue, 16 Jun 2020, Hans de Goede wrote:

> Hi,
> 
> On 6/15/20 10:49 PM, Federico Ricchiuto wrote:
> > The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does
> > not supply descriptors, so it has to be added to the override list.
> > 
> > Signed-off-by: Federico Ricchiuto <fed.ricchiuto@gmail.com>
> 
> It looks like you copied and pasted part of the commit message from
> another patch (which is fine), but you need to update the Subject
> (the first line of the commit message) the Subject now still
> mentions the Trekstor Surfbook E11B rather then the
> Mediacom FlexBook edge13.
> 
> Otherwise this looks good to me.

Thanks. I've fixed up the subject and applied.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override
  2020-02-14  8:32 ` Hans de Goede
@ 2020-02-14 10:40   ` Benjamin Tissoires
  0 siblings, 0 replies; 6+ messages in thread
From: Benjamin Tissoires @ 2020-02-14 10:40 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Kai-Heng Feng, Jiri Kosina, open list:HID CORE LAYER, open list

Hi,

On Fri, Feb 14, 2020 at 9:32 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 2/14/20 7:53 AM, Kai-Heng Feng wrote:
> > The Surfbook E11B uses the SIPODEV SP1064 touchpad, which does not supply
> > descriptors, so it has to be added to the override list.
> >
> > BugLink: https://bugs.launchpad.net/bugs/1858299
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Thanks everybody for the patch submission and the quick review.

Patch is now queued in for-5.6/upstream-fixes

Cheers,
Benjamin

>
> Regards,
>
> Hans
>
>
>
> > ---
> >   drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> > index d31ea82b84c1..a66f08041a1a 100644
> > --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> > +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> > @@ -341,6 +341,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = {
> >               },
> >               .driver_data = (void *)&sipodev_desc
> >       },
> > +     {
> > +             .ident = "Trekstor SURFBOOK E11B",
> > +             .matches = {
> > +                     DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TREKSTOR"),
> > +                     DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "SURFBOOK E11B"),
> > +             },
> > +             .driver_data = (void *)&sipodev_desc
> > +     },
> >       {
> >               .ident = "Direkt-Tek DTLAPY116-2",
> >               .matches = {
> >
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override
  2020-02-14  6:53 Kai-Heng Feng
@ 2020-02-14  8:32 ` Hans de Goede
  2020-02-14 10:40   ` Benjamin Tissoires
  0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2020-02-14  8:32 UTC (permalink / raw)
  To: Kai-Heng Feng, jikos, benjamin.tissoires
  Cc: open list:HID CORE LAYER, open list

Hi,

On 2/14/20 7:53 AM, Kai-Heng Feng wrote:
> The Surfbook E11B uses the SIPODEV SP1064 touchpad, which does not supply
> descriptors, so it has to be added to the override list.
> 
> BugLink: https://bugs.launchpad.net/bugs/1858299
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>   drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> index d31ea82b84c1..a66f08041a1a 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
> @@ -341,6 +341,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = {
>   		},
>   		.driver_data = (void *)&sipodev_desc
>   	},
> +	{
> +		.ident = "Trekstor SURFBOOK E11B",
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TREKSTOR"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "SURFBOOK E11B"),
> +		},
> +		.driver_data = (void *)&sipodev_desc
> +	},
>   	{
>   		.ident = "Direkt-Tek DTLAPY116-2",
>   		.matches = {
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override
@ 2020-02-14  6:53 Kai-Heng Feng
  2020-02-14  8:32 ` Hans de Goede
  0 siblings, 1 reply; 6+ messages in thread
From: Kai-Heng Feng @ 2020-02-14  6:53 UTC (permalink / raw)
  To: jikos, benjamin.tissoires
  Cc: Kai-Heng Feng, Hans de Goede, open list:HID CORE LAYER, open list

The Surfbook E11B uses the SIPODEV SP1064 touchpad, which does not supply
descriptors, so it has to be added to the override list.

BugLink: https://bugs.launchpad.net/bugs/1858299
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
index d31ea82b84c1..a66f08041a1a 100644
--- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
+++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
@@ -341,6 +341,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = {
 		},
 		.driver_data = (void *)&sipodev_desc
 	},
+	{
+		.ident = "Trekstor SURFBOOK E11B",
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TREKSTOR"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "SURFBOOK E11B"),
+		},
+		.driver_data = (void *)&sipodev_desc
+	},
 	{
 		.ident = "Direkt-Tek DTLAPY116-2",
 		.matches = {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-06-16 15:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 20:49 [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override Federico Ricchiuto
2020-06-16 11:30 ` Hans de Goede
2020-06-16 15:19   ` Jiri Kosina
  -- strict thread matches above, loose matches on Subject: below --
2020-02-14  6:53 Kai-Heng Feng
2020-02-14  8:32 ` Hans de Goede
2020-02-14 10:40   ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).