From: Sasha Levin <firstname.lastname@example.org> To: Linus Torvalds <email@example.com> Cc: Shuah Khan <firstname.lastname@example.org>, Konstantin Khlebnikov <email@example.com>, Joerg Roedel <firstname.lastname@example.org>, Andrew Lutomirski <email@example.com>, Peter Zijlstra <firstname.lastname@example.org>, Takashi Iwai <email@example.com>, Linux Kernel Mailing List <firstname.lastname@example.org>, the arch/x86 maintainers <email@example.com> Subject: Re: [PATCH] scripts/decode_stacktrace: warn when modpath is needed but is unset Date: Mon, 15 Jun 2020 19:24:53 -0400 [thread overview] Message-ID: <20200615232453.GF1931@sasha-vm> (raw) In-Reply-To: <CAHk-=wh2VeXjf0vPXSJzaV3zk6iNEfnumn6YDQF44OmEcGpoYw@mail.gmail.com> On Mon, Jun 15, 2020 at 03:43:31PM -0700, Linus Torvalds wrote: >On Mon, Jun 15, 2020 at 3:37 PM Linus Torvalds ><firstname.lastname@example.org> wrote: >> >> Well, that looks straightforward. > >Hmm. Decided to test it. It warns for every case: a bit excessive, >perhaps, but I guess it won't hurt. > >So Shuah's thing results in > >[ 9.791367] Call Trace: >WARNING! Modules path isn't set, but is needed to parse this symbol >[ 9.791377] ? snd_pcm_hw_params+0x3ca/0x440 snd_pcm >WARNING! Modules path isn't set, but is needed to parse this symbol >[ 9.791383] snd_pcm_common_ioctl+0x173/0xf20 snd_pcm >WARNING! Modules path isn't set, but is needed to parse this symbol >[ 9.791389] ? snd_ctl_ioctl+0x1c5/0x710 snd >WARNING! Modules path isn't set, but is needed to parse this symbol >[ 9.791394] snd_pcm_ioctl+0x27/0x40 snd_pcm > >which looks a bit redundant, but maybe that just means people _really_ notice. I figured it's a good balance between warning only once (which can get lost in a longer trace) vs just exiting on error (as it prevents the user from ignoring this issue if he doesn't care or just doesn't have the modules). -- Thanks, Sasha
next prev parent reply other threads:[~2020-06-15 23:24 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-15 18:48 Linux 5.8-rc1 BUG unable to handle page fault (snd_pcm) Shuah Khan 2020-06-15 19:47 ` David Rientjes 2020-06-15 19:48 ` Linus Torvalds 2020-06-15 20:41 ` Shuah Khan 2020-06-15 20:55 ` Linus Torvalds 2020-06-15 21:18 ` Shuah Khan 2020-06-15 22:23 ` Linus Torvalds 2020-06-15 22:24 ` [PATCH] scripts/decode_stacktrace: warn when modpath is needed but is unset Sasha Levin 2020-06-15 22:37 ` Linus Torvalds 2020-06-15 22:43 ` Linus Torvalds 2020-06-15 23:24 ` Sasha Levin [this message] 2020-06-15 19:57 ` Linux 5.8-rc1 BUG unable to handle page fault (snd_pcm) Takashi Iwai 2020-06-15 20:53 ` Shuah Khan 2020-06-15 21:04 ` Shuah Khan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200615232453.GF1931@sasha-vm \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] scripts/decode_stacktrace: warn when modpath is needed but is unset' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).