From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B613C433E0 for ; Mon, 15 Jun 2020 23:28:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 381D720739 for ; Mon, 15 Jun 2020 23:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbgFOX2Q (ORCPT ); Mon, 15 Jun 2020 19:28:16 -0400 Received: from mail106.syd.optusnet.com.au ([211.29.132.42]:58420 "EHLO mail106.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725960AbgFOX2Q (ORCPT ); Mon, 15 Jun 2020 19:28:16 -0400 Received: from dread.disaster.area (pa49-180-124-177.pa.nsw.optusnet.com.au [49.180.124.177]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 9782C5AA8C5; Tue, 16 Jun 2020 09:28:06 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1jkyWI-00019L-ER; Tue, 16 Jun 2020 09:28:02 +1000 Date: Tue, 16 Jun 2020 09:28:02 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: Waiman Long , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qian Cai , Eric Sandeen , Andrew Morton Subject: Re: [PATCH 2/2] xfs: Fix false positive lockdep warning with sb_internal & fs_reclaim Message-ID: <20200615232802.GX2040@dread.disaster.area> References: <20200615160830.8471-1-longman@redhat.com> <20200615160830.8471-3-longman@redhat.com> <20200615164351.GF11255@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200615164351.GF11255@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=QIgWuTDL c=1 sm=1 tr=0 a=k3aV/LVJup6ZGWgigO6cSA==:117 a=k3aV/LVJup6ZGWgigO6cSA==:17 a=kj9zAlcOel0A:10 a=nTHF0DUjJn0A:10 a=7-415B0cAAAA:8 a=d-5gr-WEPLwAlw7X_sIA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2020 at 09:43:51AM -0700, Darrick J. Wong wrote: > Also: Why not set PF_MEMALLOC_NOFS at the start of the freeze call > chain? Because there's no guarantee that we are always going to do this final work in the freeze syscall context? i.e. the state is specific to the context in which we are running the transaction, not the task context it is running in... Cheers, Dave. -- Dave Chinner david@fromorbit.com