From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, PDS_BTC_ID,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 071AEC433E0 for ; Tue, 16 Jun 2020 06:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D05542074D for ; Tue, 16 Jun 2020 06:54:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YOLSQ/hH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbgFPGyk (ORCPT ); Tue, 16 Jun 2020 02:54:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbgFPGyj (ORCPT ); Tue, 16 Jun 2020 02:54:39 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2325C05BD43 for ; Mon, 15 Jun 2020 23:54:37 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id h5so19532999wrc.7 for ; Mon, 15 Jun 2020 23:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ZEPVAfPR98ffU4HcJ8n3O8Rs7VWQME5L+qY7xcPu2Q8=; b=YOLSQ/hHlyuz2FCheCDZnw7IDNAt7C64qby+01Mik/jYlMiCkM9fd013FSkvy6giKR visuSburUxrjaqyExw+hBUK//ffRx0/pjslvGves3L7lq0ZTGMttXCJcZJy1B/8+142G OMPJUxKWNpTMFJFTC4wyT27oZ0EvzaSQe8nTY4G6lpAh5kMOT/pP81OqWJaeCH9uFoC1 XUN4MIWbzy4G1FMhHGK49n0wlPJZ7Fp2u5Gw1VGVZHmkZ+FPsvxDWcf9e65ZT57/g5OU fEhRH16WcE1MKwvhd8lpRY1T6D2lwGlv1GxZFlI0acMntyVLG2Y+FV8Uv7QsNhA6Ya7Q g4bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ZEPVAfPR98ffU4HcJ8n3O8Rs7VWQME5L+qY7xcPu2Q8=; b=Lr0B0fZYC9WC6guqPywo0u+BqApHpY/A79AxpH3E6uaThFbZNCUfl9/FxhK8Oofaof t2+x8X/CybALx5m0BSqFwxFntn3SyfDFlR8W8x6Osw5iJj5ErO58GJPWwUYRfxnPufDT Qkcid4kczqO1yIyj56JPhfvRPlEupC/BMaz8XsiFHESFC1DkcjKU74LYBtybOFRw6rr5 98JXgLBd2lUtthDJ61vHqK9JvrPHIs2YenD/P26O0ihykavODnpv7dlumQfbzsWnddDE FHdJzCs0IxjKVTWV4cj37A6mBO6FIfCvr0BmVlAHEY1F/H6Tdnc2S7G4up2SuGddugu3 y/8w== X-Gm-Message-State: AOAM533gqWYqBSpVc/lYdhBuC7bCgq+J+ymvlSPF7PXKtsVDxVr5zodo SsXYvVOHur6ERvg/mRrM1gJ8fQ== X-Google-Smtp-Source: ABdhPJxI0GVoVyQ/MRgIv7AiXuVqi6L+3wuLe52/Bl06xZTxe35y0eMPzlD2ew8Wb+5/cLTvsbP//Q== X-Received: by 2002:adf:f552:: with SMTP id j18mr1318126wrp.279.1592290476475; Mon, 15 Jun 2020 23:54:36 -0700 (PDT) Received: from vingu-book ([2a01:e0a:f:6020:5592:7b9c:f9d9:6edb]) by smtp.gmail.com with ESMTPSA id g187sm2682245wma.17.2020.06.15.23.54.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jun 2020 23:54:35 -0700 (PDT) Date: Tue, 16 Jun 2020 08:54:32 +0200 From: Vincent Guittot To: Xing Zhengjun Cc: Hillf Danton , kernel test robot , Ingo Molnar , Mel Gorman , Peter Zijlstra , Juri Lelli , Steven Rostedt , Valentin Schneider , Phil Auld , LKML Subject: Re: [LKP] [sched/fair] 070f5e860e: reaim.jobs_per_min -10.5% regression Message-ID: <20200616065432.GA18401@vingu-book> References: <20200319023819.GO11705@shao2-debian> <20200612110616.20264-1-hdanton@sina.com> <90f4036d-bb16-af67-8776-a2cbe67dfe7f@linux.intel.com> <20200615081041.GA16990@vingu-book> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xing, Le mardi 16 juin 2020 à 11:17:16 (+0800), Xing Zhengjun a écrit : > > > On 6/15/2020 4:10 PM, Vincent Guittot wrote: > > Hi Xing, > > > > Le lundi 15 juin 2020 à 15:26:59 (+0800), Xing Zhengjun a écrit : > > > > > > > > > On 6/12/2020 7:06 PM, Hillf Danton wrote: > > > > > > > > On Fri, 12 Jun 2020 14:36:49 +0800 Xing Zhengjun wrote: > > ... > > > > I apply the patch based on v5.7, the test result is as the following: TBH, I didn't expect that the results would still be bad, so i wonder if the threshold are the root problem. Could you run tests with the patch below that removes condition with runnable_avg ? I just want to make sure that those 2 conditions are the root cause. diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index da3e5b54715b..f5774d0af059 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8210,10 +8210,6 @@ group_has_capacity(unsigned int imbalance_pct, struct sg_lb_stats *sgs) if (sgs->sum_nr_running < sgs->group_weight) return true; - if ((sgs->group_capacity * imbalance_pct) < - (sgs->group_runnable * 100)) - return false; - if ((sgs->group_capacity * 100) > (sgs->group_util * imbalance_pct)) return true; @@ -8239,10 +8235,6 @@ group_is_overloaded(unsigned int imbalance_pct, struct sg_lb_stats *sgs) (sgs->group_util * imbalance_pct)) return true; - if ((sgs->group_capacity * imbalance_pct) < - (sgs->group_runnable * 100)) - return true; - return false; } Thanks. Vincent > > ========================================================================================= > tbox_group/testcase/rootfs/kconfig/compiler/runtime/nr_task/debug-setup/test/cpufreq_governor/ucode: > > lkp-ivb-d04/reaim/debian-x86_64-20191114.cgz/x86_64-rhel-7.6/gcc-7/300s/100%/test/five_sec/performance/0x21 > > commit: > 9f68395333ad7f5bfe2f83473fed363d4229f11c > 070f5e860ee2bf588c99ef7b4c202451faa48236 > v5.7 > 3e1643da53f3fc7414cfa3ad2a16ab2a164b7f4d (the test patch) > > 9f68395333ad7f5b 070f5e860ee2bf588c99ef7b4c2 v5.7 > 3e1643da53f3fc7414cfa3ad2a1 > ---------------- --------------------------- --------------------------- > --------------------------- > %stddev %change %stddev %change %stddev %change > %stddev > \ | \ | \ > | \ > 0.69 -10.3% 0.62 -9.1% 0.62 > -7.1% 0.64 reaim.child_systime > 0.62 -1.0% 0.61 +0.5% 0.62 > +1.3% 0.63 reaim.child_utime > 66870 -10.0% 60187 -7.6% 61787 > -6.1% 62807 reaim.jobs_per_min > 16717 -10.0% 15046 -7.6% 15446 > -6.1% 15701 reaim.jobs_per_min_child > 97.84 -1.1% 96.75 -0.4% 97.43 > -0.5% 97.34 reaim.jti > 72000 -10.8% 64216 -8.3% 66000 > -5.7% 67885 reaim.max_jobs_per_min > 0.36 +10.6% 0.40 +7.8% 0.39 > +6.9% 0.38 reaim.parent_time > 1.58 ± 2% +71.0% 2.70 ± 2% +26.9% 2.01 ± 2% > +32.5% 2.09 ± 6% reaim.std_dev_percent > 0.00 ± 5% +110.4% 0.01 ± 3% +48.8% 0.01 ± 7% > +61.7% 0.01 ± 8% reaim.std_dev_time > 50800 -2.4% 49600 -1.6% 50000 > -1.3% 50133 reaim.workload > > > > > > > > ========================================================================================= > > > tbox_group/testcase/rootfs/kconfig/compiler/runtime/nr_task/debug-setup/test/cpufreq_governor/ucode: > > > > > > lkp-ivb-d04/reaim/debian-x86_64-20191114.cgz/x86_64-rhel-7.6/gcc-7/300s/100%/test/five_sec/performance/0x21 > > > > > > commit: > > > 9f68395333ad7f5bfe2f83473fed363d4229f11c > > > 070f5e860ee2bf588c99ef7b4c202451faa48236 > > > v5.7 > > > 6b33257768b8dd3982054885ea310871be2cfe0b (Hillf's patch) > > > > > > 9f68395333ad7f5b 070f5e860ee2bf588c99ef7b4c2 v5.7 > > > 6b33257768b8dd3982054885ea3 > > > ---------------- --------------------------- --------------------------- > > > --------------------------- > > > %stddev %change %stddev %change %stddev %change > > > %stddev > > > \ | \ | \ > > > | \ > > > 0.69 -10.3% 0.62 -9.1% 0.62 > > > -10.1% 0.62 reaim.child_systime > > > 0.62 -1.0% 0.61 +0.5% 0.62 > > > +0.3% 0.62 reaim.child_utime > > > 66870 -10.0% 60187 -7.6% 61787 > > > -8.3% 61305 reaim.jobs_per_min > > > 16717 -10.0% 15046 -7.6% 15446 > > > -8.3% 15326 reaim.jobs_per_min_child > > > 97.84 -1.1% 96.75 -0.4% 97.43 > > > -0.5% 97.37 reaim.jti > > > 72000 -10.8% 64216 -8.3% 66000 > > > -8.3% 66000 reaim.max_jobs_per_min > > > 0.36 +10.6% 0.40 +7.8% 0.39 > > > +9.4% 0.39 reaim.parent_time > > > 1.58 ± 2% +71.0% 2.70 ± 2% +26.9% 2.01 ± 2% > > > +33.2% 2.11 reaim.std_dev_percent > > > 0.00 ± 5% +110.4% 0.01 ± 3% +48.8% 0.01 ± 7% > > > +65.3% 0.01 ± 3% reaim.std_dev_time > > > 50800 -2.4% 49600 -1.6% 50000 > > > -1.8% 49866 reaim.workload > > > > > > > > > > > > -- > > > Zhengjun Xing > > -- > Zhengjun Xing