From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 917CCC433E1 for ; Tue, 16 Jun 2020 06:59:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 765482074D for ; Tue, 16 Jun 2020 06:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726988AbgFPG75 (ORCPT ); Tue, 16 Jun 2020 02:59:57 -0400 Received: from mga04.intel.com ([192.55.52.120]:42770 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726384AbgFPG74 (ORCPT ); Tue, 16 Jun 2020 02:59:56 -0400 IronPort-SDR: 1Y547nM1lSz1tWLB67GevE2KXgoE4XKpfycuysg8ps7ptraaEYKqhlrSERYxpjWF12AahjqXgt sve9cc5N5/SA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2020 23:59:56 -0700 IronPort-SDR: 8BLa8egR+d0BceuadNnqir5piIf7i4xRMu4AhfKEI5XBxLk8UY/y1Jgn9pwTnW/jKhpBlfHZgO wI1AEoIK+2dA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,518,1583222400"; d="scan'208";a="420663416" Received: from chenyu-office.sh.intel.com ([10.239.158.173]) by orsmga004.jf.intel.com with ESMTP; 15 Jun 2020 23:59:52 -0700 Date: Tue, 16 Jun 2020 15:01:01 +0800 From: Chen Yu To: "Brown, Aaron F" Cc: "Kirsher, Jeffrey T" , "David S. Miller" , Jakub Kicinski , "Kok, Auke-jan H" , Jeff Garzik , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Brown, Len" , "Rafael J. Wysocki" , "Shevchenko, Andriy" , "Neftin, Sasha" , "Lifshits, Vitaly" , "Stable@vger.kernel.org" Subject: Re: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled Message-ID: <20200616070101.GA24567@chenyu-office.sh.intel.com> References: <9f7ede2e2e8152704258fc11ba3755ae93f50741.1590081982.git.yu.c.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 02:51:27AM +0800, Brown, Aaron F wrote: > > From: Chen Yu > > Sent: Thursday, May 21, 2020 10:59 AM > > To: Kirsher, Jeffrey T ; David S. Miller > > ; Jakub Kicinski ; Kok, Auke-jan H > > ; Jeff Garzik > > Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux- > > kernel@vger.kernel.org; Brown, Len ; Rafael J. Wysocki > > ; Shevchenko, Andriy ; > > Neftin, Sasha ; Lifshits, Vitaly > > ; Chen, Yu C ; > > Stable@vger.kernel.org > > Subject: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device > > wakeup is disabled > > > > Currently the system will be woken up via WOL(Wake On Lan) even if the > > device wakeup ability has been disabled via sysfs: > > cat /sys/devices/pci0000:00/0000:00:1f.6/power/wakeup > > disabled > > > > The system should not be woken up if the user has explicitly > > disabled the wake up ability for this device. > > > > This patch clears the WOL ability of this network device if the > > user has disabled the wake up ability in sysfs. > > > > Fixes: bc7f75fa9788 ("[E1000E]: New pci-express e1000 driver") > > Reported-by: Rafael J. Wysocki > > Reviewed-by: Andy Shevchenko > > Cc: > > Signed-off-by: Chen Yu > > --- > > drivers/net/ethernet/intel/e1000e/netdev.c | 14 ++++++++++---- > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > Tested-by: Aaron Brown > Thanks for testing, Aaron. Best, Chenyu