From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F011C433DF for ; Tue, 16 Jun 2020 10:40:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6978D20786 for ; Tue, 16 Jun 2020 10:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592304012; bh=7dldRWO7gGRPlZ/8sV26jPzle1h5yQEqABWokXqyW38=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=R7aQ7nRB83yMRZXQ42e2Lj3VwMIvYEjaEhbh9jSgMB7n3ma/7LZJxSg27e6/CiKCn FQ/pLYJJkcubfmXPyl2KOh9qoSR3Pb2U3y8J1M1/twCluF+qZcAkF7wtXOQ7FVA6pI V2lTzh1arpK21biNYCuzyVl3zsEZWzBHOwsQusm4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728386AbgFPKkK (ORCPT ); Tue, 16 Jun 2020 06:40:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:56088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbgFPKj7 (ORCPT ); Tue, 16 Jun 2020 06:39:59 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EA0320786; Tue, 16 Jun 2020 10:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592303998; bh=7dldRWO7gGRPlZ/8sV26jPzle1h5yQEqABWokXqyW38=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s3YG0XKIGUKezsbFPu+LsttzfENLcVz6uOAgoe8u3j2JVe5uZvas/7wxHmBbu6K9t ALdsxYeae+Xo/DSQ0UB0LtxZzXhGyfjKzGlO9MCz7WZaFInHWsgW/aTqaIQ1kR92IS kp6WqPseGrtvHr9CykwXRzc0VOenTXqXbSlzpie0= Date: Tue, 16 Jun 2020 11:39:56 +0100 From: Mark Brown To: Krzysztof Kozlowski Cc: Thomas Gleixner , Vladimir Oltean , linux-spi@vger.kernel.org, "linux-kernel@vger.kernel.org" , Marc Kleine-Budde , Wolfram Sang , kernel@pengutronix.de Subject: Re: [PATCH v2 3/3] genirq: Do not test disabled IRQs with DEBUG_SHIRQ Message-ID: <20200616103956.GL4447@sirena.org.uk> References: <1592208439-17594-1-git-send-email-krzk@kernel.org> <1592208439-17594-3-git-send-email-krzk@kernel.org> <20200615120844.GL4447@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/0D4jGRsNl8cPNu/" Content-Disposition: inline In-Reply-To: X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/0D4jGRsNl8cPNu/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 16, 2020 at 12:11:17PM +0200, Krzysztof Kozlowski wrote: > On Mon, Jun 15, 2020 at 01:08:44PM +0100, Mark Brown wrote: > > On Mon, Jun 15, 2020 at 10:07:19AM +0200, Krzysztof Kozlowski wrote: > > > Testing events during freeing of disabled shared interrupts > > > (CONFIG_DEBUG_SHIRQ) leads to false positives. The driver disabled > > > interrupts on purpose to be sure that they will not fire during device > > > removal. > > Surely the whole issue with shared IRQs that's being tested for here is > > that when the interrupt is shared some other device connected to the > > same interrupt line may trigger an interrupt regardless of what's going > > on with this device? > Yes. However if that device disabled the interrupt, it should not be > fired for other users. In such case the testing does not point to a > real issue. To be honest I'd say that if you're disabling a shared interrupt that's a bit of an issue regardless of anything else that's going on, it'll disrupt other devices connected to it. --/0D4jGRsNl8cPNu/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7ooXsACgkQJNaLcl1U h9DoHgf+JwvDuPobncELlcEI/vWSGXCrDuPyH/+FJU0Ji63DjRavjk3dt7UI1UsD m70QleSoyhqku2gmsEnWKgRz08Y3KD8XCX6L/LwqmB2GKuZLlV2qHdgr6UkJ1UQ1 XOF2w75Vip+CnBp6AlVuEGyJ9k32y6VGDXyAe8nkFZU1teHMEZ2BPv8ZwrtHIgjs /Mq6GUrSDXYSWkDD1AhLBG+ZjuCWm/UBy5anxCbAcnlIADxHVfLLzL58CPtOYNpy 03RoSphUoITpHPlTssE5VGdByMnxY7116n0XbiCsP6+mVmm/KU9FpHwOYN5qmFWS hFrkjmbsmqNIpLXjzKQBxAiyDk5G0g== =x0XR -----END PGP SIGNATURE----- --/0D4jGRsNl8cPNu/--