From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C9EAC433E2 for ; Tue, 16 Jun 2020 10:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E01C120739 for ; Tue, 16 Jun 2020 10:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728539AbgFPKu5 (ORCPT ); Tue, 16 Jun 2020 06:50:57 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:53312 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbgFPKu5 (ORCPT ); Tue, 16 Jun 2020 06:50:57 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 1B0FC1C0BD2; Tue, 16 Jun 2020 12:50:56 +0200 (CEST) Date: Tue, 16 Jun 2020 12:50:45 +0200 From: Pavel Machek To: Merlijn Wajer Cc: Sebastian Reichel , Tony Lindgren , Beno??t Cousson , Rob Herring , Dmitry Torokhov , Greg Kroah-Hartman , Borislav Petkov , Andy Shevchenko , Manivannan Sadhasivam , Thomas Gleixner , Mattias Jacobsson <2pi@mok.nu>, Mark Gross , Russell King , "open list:OMAP DEVICE TREE SUPPORT" , "open list:OMAP DEVICE TREE SUPPORT" , open list , "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." Subject: Re: [PATCH 1/2] Input: add `SW_MACHINE_COVER` Message-ID: <20200616105045.GB1718@bug> References: <20200612125402.18393-1-merlijn@wizzup.org> <20200612125402.18393-2-merlijn@wizzup.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200612125402.18393-2-merlijn@wizzup.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2020-06-12 14:53:58, Merlijn Wajer wrote: > This event code represents the state of a removable cover of a device. > Value 0 means that the cover is open or removed, value 1 means that the > cover is closed. > > Reviewed-by: Sebastian Reichel Acked-by: Tony Lindgren > Signed-off-by: Merlijn Wajer --- Dmitry, can we get some kind of comment here, or better yet can we get you to apply this? Thanks, Pavel > +++ b/include/linux/mod_devicetable.h > @@ -318,7 +318,7 @@ struct pcmcia_device_id { > #define INPUT_DEVICE_ID_LED_MAX 0x0f > #define INPUT_DEVICE_ID_SND_MAX 0x07 > #define INPUT_DEVICE_ID_FF_MAX 0x7f > -#define INPUT_DEVICE_ID_SW_MAX 0x0f > +#define INPUT_DEVICE_ID_SW_MAX 0x10 > #define INPUT_DEVICE_ID_PROP_MAX 0x1f > > #define INPUT_DEVICE_ID_MATCH_BUS 1 > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h > index b6a835d37826..0c2e27d28e0a 100644 > --- a/include/uapi/linux/input-event-codes.h > +++ b/include/uapi/linux/input-event-codes.h > @@ -888,7 +888,8 @@ > #define SW_LINEIN_INSERT 0x0d /* set = inserted */ > #define SW_MUTE_DEVICE 0x0e /* set = device disabled */ > #define SW_PEN_INSERTED 0x0f /* set = pen inserted */ > -#define SW_MAX 0x0f > +#define SW_MACHINE_COVER 0x10 /* set = cover closed */ > +#define SW_MAX 0x10 > #define SW_CNT (SW_MAX+1) > > /* > -- > 2.24.1 -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html