From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA6EC433E0 for ; Tue, 16 Jun 2020 10:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9727D20786 for ; Tue, 16 Jun 2020 10:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728494AbgFPKyl (ORCPT ); Tue, 16 Jun 2020 06:54:41 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:53754 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbgFPKyj (ORCPT ); Tue, 16 Jun 2020 06:54:39 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id A00DE1C0BD2; Tue, 16 Jun 2020 12:54:38 +0200 (CEST) Date: Tue, 16 Jun 2020 12:54:29 +0200 From: Pavel Machek To: Dan Murphy Cc: jacek.anaszewski@gmail.com, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v27 03/15] leds: multicolor: Introduce a multicolor class definition Message-ID: <20200616105429.GI1718@bug> References: <20200608193917.13084-1-dmurphy@ti.com> <20200608193917.13084-4-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200608193917.13084-4-dmurphy@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > +static ssize_t multi_intensity_show(struct device *dev, > + struct device_attribute *intensity_attr, > + char *buf) > +{ > + struct led_classdev *led_cdev = dev_get_drvdata(dev); > + struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev); > + int len = 0; > + int i; > + > + for (i = 0; i < mcled_cdev->num_colors; i++) { > + len += sprintf(buf + len, "%d", > + mcled_cdev->subled_info[i].intensity); > + if (i < mcled_cdev->num_colors) > + len += sprintf(buf + len, " "); Always false, AFAICT. Pavel