From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349E8C433E1 for ; Tue, 16 Jun 2020 14:41:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2158520644 for ; Tue, 16 Jun 2020 14:41:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729286AbgFPOlY (ORCPT ); Tue, 16 Jun 2020 10:41:24 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:33644 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728501AbgFPOlY (ORCPT ); Tue, 16 Jun 2020 10:41:24 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 624471C0BD2; Tue, 16 Jun 2020 16:41:22 +0200 (CEST) Date: Tue, 16 Jun 2020 16:41:22 +0200 From: Pavel Machek To: Sasha Levin Cc: Thomas Zimmermann , alexander.deucher@amd.com, chris@chris-wilson.co.uk, ville.syrjala@linux.intel.com, Hawking.Zhang@amd.com, tvrtko.ursulin@intel.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, spronovo@microsoft.com, iourit@microsoft.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [RFC PATCH 0/4] DirectX on Linux Message-ID: <20200616144122.GA18447@duo.ucw.cz> References: <20200519163234.226513-1-sashal@kernel.org> <55c57049-1869-7421-aa0f-3ce0b6a133cf@suse.de> <20200616105112.GC1718@bug> <20200616132819.GP1931@sasha-vm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <20200616132819.GP1931@sasha-vm> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2020-06-16 09:28:19, Sasha Levin wrote: > On Tue, Jun 16, 2020 at 12:51:13PM +0200, Pavel Machek wrote: > > Hi! > >=20 > > > > The driver creates the /dev/dxg device, which can be opened by user= mode > > > > application and handles their ioctls. The IOCTL interface to the dr= iver > > > > is defined in dxgkmthk.h (Dxgkrnl Graphics Port Driver ioctl > > > > definitions). The interface matches the D3DKMT interface on Windows. > > > > Ioctls are implemented in ioctl.c. > > >=20 > > > Echoing what others said, you're not making a DRM driver. The driver = should live outside > > > of the DRM code. > > >=20 > >=20 > > Actually, this sounds to me like "this should not be merged into linux = kernel". I mean, > > we already have DRM API on Linux. We don't want another one, do we? >=20 > This driver doesn't have any display functionality. Graphics cards without displays connected are quite common. I may be wrong, but I believe we normally handle them using DRM... > > And at the very least... this misses API docs for /dev/dxg. Code can't = really > > be reviewed without that. >=20 > The docs live here: https://docs.microsoft.com/en-us/windows-hardware/dri= vers/ddi/d3dkmthk/ I don't see "/dev/dxg" being metioned there. Plus, kernel API documentation should really go to Documentation, and be suitably licensed. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXujaEgAKCRAw5/Bqldv6 8q/JAKCQjRPnkrFqnsMWU0xDN/FHE1enzwCeMHA4YAkm0yQfrg+8eKiMWa/ARU8= =bHer -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--