From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C460CC433E0 for ; Tue, 16 Jun 2020 16:09:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A75192071A for ; Tue, 16 Jun 2020 16:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592323743; bh=338AucczY2mLow4d9IdceneS8Dm9fzEUvS1ZacGLH8w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DAd/cI9C5fXWsdoHDE5G5+CLur/RakNO6Y5Wi39rSLS8jirtDVVjDBVnMruNcOEJo /aMmjii2XJLO0NkOdoYg6uZs0bG3p2OgHARgz0vx1e/AG2XGKx2L7mgziP+/1R7W+1 QVFi2MJIY6/31yCP4r7a0wsG4OBAyuBnbH2AukC0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732351AbgFPQJB (ORCPT ); Tue, 16 Jun 2020 12:09:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:37126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732106AbgFPPpk (ORCPT ); Tue, 16 Jun 2020 11:45:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2FBFC21473; Tue, 16 Jun 2020 15:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592322339; bh=338AucczY2mLow4d9IdceneS8Dm9fzEUvS1ZacGLH8w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EsRJaYhPVZ6bfapUbC1lGmIH1YAn+A30Fg2wjXlrttWnLH4Sd2fUU05ShqLzuj0WK PbVrLz60WDKssCtnyVwARpjESzF86s+vD2FfGynLB/TE0M9BAnR61lzE5aJSvnCDK6 1VMiiJiQt5jp4N7fYwG6PEfWopb+zvniygYc29Ts= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Takashi Iwai Subject: [PATCH 5.7 063/163] ALSA: es1688: Add the missed snd_card_free() Date: Tue, 16 Jun 2020 17:33:57 +0200 Message-Id: <20200616153109.863722643@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200616153106.849127260@linuxfoundation.org> References: <20200616153106.849127260@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan commit d9b8fbf15d05350b36081eddafcf7b15aa1add50 upstream. snd_es968_pnp_detect() misses a snd_card_free() in a failed path. Add the missed function call to fix it. Fixes: a20971b201ac ("ALSA: Merge es1688 and es968 drivers") Signed-off-by: Chuhong Yuan Cc: Link: https://lore.kernel.org/r/20200603092459.1424093-1-hslester96@gmail.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/isa/es1688/es1688.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/sound/isa/es1688/es1688.c +++ b/sound/isa/es1688/es1688.c @@ -267,8 +267,10 @@ static int snd_es968_pnp_detect(struct p return error; } error = snd_es1688_probe(card, dev); - if (error < 0) + if (error < 0) { + snd_card_free(card); return error; + } pnp_set_card_drvdata(pcard, card); snd_es968_pnp_is_probed = 1; return 0;