From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7030C433E0 for ; Tue, 16 Jun 2020 15:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEF38207C4 for ; Tue, 16 Jun 2020 15:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592323075; bh=cB0xYbRke6CaPhv+2x3VkaVLolCq4Lq7+R793GDpnis=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xq98jonpQ7CvxO1tqA3PGxEAlKaemTugn2qmH6bEtd45kyGNBNOp0iI6aozFMHMOr asA/94zutZeRihaBBmCUW50uYv+qP6WxtWFzTpD/gGrQu72VsPTWe8n5v7RSj1Z5I2 ckm1SO57kKrnAn80PPweO8ZAL/1hgPN4CwRqmoX4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733003AbgFPPyj (ORCPT ); Tue, 16 Jun 2020 11:54:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:53780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732991AbgFPPy3 (ORCPT ); Tue, 16 Jun 2020 11:54:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C8364207C4; Tue, 16 Jun 2020 15:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592322869; bh=cB0xYbRke6CaPhv+2x3VkaVLolCq4Lq7+R793GDpnis=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tbs3KAJXWBIZ+DHAG+gsceJsXfdgI/CWSUwS0WF5lzi3lojot1sCxJF+yChNLrg6r z66sok+NXutI4ueCRYrsfW1dg2mXc5h+YZl8H5PhGYm/v8Djx25XeisyBvbTNgw7Oo OB+CeJKTDIuOhd+/Ewqa4FUEacrjjtkFK5xTyWzA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Martin K. Petersen" , Eric Biggers , Herbert Xu Subject: [PATCH 5.6 096/161] crypto: algapi - Avoid spurious modprobe on LOADED Date: Tue, 16 Jun 2020 17:34:46 +0200 Message-Id: <20200616153110.949933399@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200616153106.402291280@linuxfoundation.org> References: <20200616153106.402291280@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Biggers commit beeb460cd12ac9b91640b484b6a52dcba9d9fc8f upstream. Currently after any algorithm is registered and tested, there's an unnecessary request_module("cryptomgr") even if it's already loaded. Also, CRYPTO_MSG_ALG_LOADED is sent twice, and thus if the algorithm is "crct10dif", lib/crc-t10dif.c replaces the tfm twice rather than once. This occurs because CRYPTO_MSG_ALG_LOADED is sent using crypto_probing_notify(), which tries to load "cryptomgr" if the notification is not handled (NOTIFY_DONE). This doesn't make sense because "cryptomgr" doesn't handle this notification. Fix this by using crypto_notify() instead of crypto_probing_notify(). Fixes: dd8b083f9a5e ("crypto: api - Introduce notifier for new crypto algorithms") Cc: # v4.20+ Cc: Martin K. Petersen Signed-off-by: Eric Biggers Reviewed-by: Martin K. Petersen Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- crypto/algapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/crypto/algapi.c +++ b/crypto/algapi.c @@ -403,7 +403,7 @@ static void crypto_wait_for_test(struct err = wait_for_completion_killable(&larval->completion); WARN_ON(err); if (!err) - crypto_probing_notify(CRYPTO_MSG_ALG_LOADED, larval); + crypto_notify(CRYPTO_MSG_ALG_LOADED, larval); out: crypto_larval_kill(&larval->alg);