From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78771C433DF for ; Tue, 16 Jun 2020 22:12:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 528622082E for ; Tue, 16 Jun 2020 22:12:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="K+ndqAaP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726101AbgFPWMC (ORCPT ); Tue, 16 Jun 2020 18:12:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725964AbgFPWMB (ORCPT ); Tue, 16 Jun 2020 18:12:01 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E70A7C0613ED for ; Tue, 16 Jun 2020 15:11:59 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id ga6so23725pjb.1 for ; Tue, 16 Jun 2020 15:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IAntcGVr69jG+2U9Kg/0cnUckvFxjteOolkcxbeRc9Y=; b=K+ndqAaPDXsilMqepmXfCMFmGehmMghRgs/uYLROhyx6CasKx/nZUoyOyDLdqq2piY C/V3d1JkmyubwTahebBr/V7/usnD6QdgIQXr35pyGRbVh4GWwwV8dAs7yvQIDrSWKDAc ZHAVHA9KluaJyFPwX8WCoEpPL0TWDallcZXXU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IAntcGVr69jG+2U9Kg/0cnUckvFxjteOolkcxbeRc9Y=; b=smKRw0c1PBLn7H3mTuUfiRVI3gFxqG/gIT6HY/qzIKI/2fFvAGqXixm/8KSqbDWQwf CM7vJwqw5/JMM10KXxUiHxzC62bpEM5wdEOpYJhdC8xLDkkWcL8SMI0Wfm9tkihdSd4I OqUCKW44aEUSJbwpasWHR0J8PW415sBoq1Brn9VF+OF1K5Sw28M6brbQu2Pu3Ha9QAFg ao+77bnIIOVIpc/m3z68eRfG/86RA9+XY3Ti1IqbittX+YSPw54gHkAzbFfiT58ZGscP I0Zsa1c1SqmszQiP0nBLgyvs7UQwdxhyjjRu65avX15UxKJQe+O67D6U5E1flGyEHO4j EDFw== X-Gm-Message-State: AOAM5311pyZZT7U7RbIkwfli4qw+RgfzdvbGPdQZcYazMMMHKqkxtPuH UoCw801hFI8iVFBL3eCGYjSzfQ== X-Google-Smtp-Source: ABdhPJzSnCJjDw+p1Ezp/HhEv4OF149xFwUoopIq0eaTwuT98NS0ayzkV4ddBqNuQJGzJMA3vaFiHQ== X-Received: by 2002:a17:90b:19c4:: with SMTP id nm4mr4994217pjb.66.1592345519448; Tue, 16 Jun 2020 15:11:59 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 73sm15563491pge.15.2020.06.16.15.11.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 15:11:58 -0700 (PDT) Date: Tue, 16 Jun 2020 15:11:57 -0700 From: Matthias Kaehlcke To: Sibi Sankar Cc: viresh.kumar@linaro.org, sboyd@kernel.org, georgi.djakov@linaro.org, saravanak@google.com, nm@ti.com, bjorn.andersson@linaro.org, agross@kernel.org, rjw@rjwysocki.net, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dianders@chromium.org, vincent.guittot@linaro.org, amit.kucheria@linaro.org, lukasz.luba@arm.com, sudeep.holla@arm.com, smasetty@codeaurora.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH v6 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change Message-ID: <20200616221157.GA4525@google.com> References: <20200605213332.609-1-sibis@codeaurora.org> <20200605213332.609-5-sibis@codeaurora.org> <20200615172553.GU4525@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sibi, after doing the review I noticed that Viresh replied on the cover letter that he picked the series up for v5.9, so I'm not sure if it makes sense to send a v7. On Wed, Jun 17, 2020 at 02:35:00AM +0530, Sibi Sankar wrote: > > > @@ -112,7 +178,7 @@ static int qcom_cpufreq_hw_read_lut(struct > > > device *cpu_dev, > > > > > > if (freq != prev_freq && core_count != LUT_TURBO_IND) { > > > table[i].frequency = freq; > > > - dev_pm_opp_add(cpu_dev, freq * 1000, volt); > > > + qcom_cpufreq_update_opp(cpu_dev, freq, volt); > > > > This is the cross-validation mentioned above, right? Shouldn't it > > include > > a check of the return value? > > Yes, this is the cross-validation step, > we adjust the voltage if opp-tables are > present/added successfully and enable > them, else we would just do a add opp. > We don't want to exit early on a single > opp failure. We will error out a bit > later if the opp-count ends up to be > zero. At least an error/warning message would seem convenient when adjusting/adding an OPP fails, otherwise you would only notice by looking at the sysfs attributes (if you'd even spot a single/few OPPs to be missing).