From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03048C433DF for ; Wed, 17 Jun 2020 08:25:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C929B20679 for ; Wed, 17 Jun 2020 08:25:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Pcm2agFe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726510AbgFQIZd (ORCPT ); Wed, 17 Jun 2020 04:25:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbgFQIZd (ORCPT ); Wed, 17 Jun 2020 04:25:33 -0400 Received: from merlin.infradead.org (unknown [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE3B4C061573; Wed, 17 Jun 2020 01:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NAXZqH3MursAn0+wgZd0xhoxT3Om8ZNhr3AOj88BNwA=; b=Pcm2agFeAxquPL5LAngzPzjqIq E1O1mPL7BGCp5Eq/PFuKmucc/Uf5gXHhFL64YoiDF5UUJEnoleTZY7DW++UfrzE3aAMdAPrpugq5i 8Xrj0NtyY+QCer/HMMKYK48+GSVWNVNIRAZgvR2jG0efnVUh9mMfryhyZpI9WPJPVLLPhDl7VGpF5 ZayVIN0VtRSOJQc6xYWrTD06Czu3DoL8zXxSIFXpo3dALqCcYApPxnc0L0L4dHzT1gYTYX5z9ACpY VlD6xfD3HocQKBCqUU/zXLWpMVsdHiq2EV2/I3Lz0eBeK35Ruozq7lysC5Nk72FIsIBe4VewUgA5N uTstIriQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlTNW-0006ko-9Y; Wed, 17 Jun 2020 08:25:02 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 43972301DFC; Wed, 17 Jun 2020 10:24:59 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 0F22829E5A2E3; Wed, 17 Jun 2020 10:24:59 +0200 (CEST) Date: Wed, 17 Jun 2020 10:24:59 +0200 From: Peter Zijlstra To: Herbert Xu Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Linux Kernel Mailing List , Ingo Molnar , Will Deacon , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-s390@vger.kernel.org Subject: Re: [v3 PATCH 1/2] lockdep: Split header file into lockdep and lockdep_types Message-ID: <20200617082459.GC2531@hirez.programming.kicks-ass.net> References: <20200617071524.GA3055@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2020 at 05:17:19PM +1000, Herbert Xu wrote: > There is a header file inclusion loop between asm-generic/bug.h > and linux/kernel.h. This causes potential compile failurs depending > on the which file is included first. One way of breaking this loop > is to stop spinlock_types.h from including lockdep.h. This patch > splits lockdep.h into two files for this purpose. > > Signed-off-by: Herbert Xu > Reviewed-by: Andy Shevchenko > Reviewed-by: Sergey Senozhatsky > Acked-by: Petr Mladek > Acked-by: Steven Rostedt (VMware) Looks good. Petr, how about I stick this in tip/locking/header for us both to share?