From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40809C433DF for ; Wed, 17 Jun 2020 08:32:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1847A206E2 for ; Wed, 17 Jun 2020 08:32:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="pGHQQ40P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbgFQIb7 (ORCPT ); Wed, 17 Jun 2020 04:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726708AbgFQIb6 (ORCPT ); Wed, 17 Jun 2020 04:31:58 -0400 Received: from merlin.infradead.org (unknown [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8ADBC061573 for ; Wed, 17 Jun 2020 01:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PpSWQoZVa+rxLKWKXqLIv8btjA0lR/+HCKmuqJBW6Xk=; b=pGHQQ40PYz4XaECx9UDuuOmLNJ iEv5F88GbuYBu2poejXdWHicH5VKt9K55XNs+X7kjcA4Ziud4AiW8B9/kkzms7DKrt5D5SkXyRJ7i 13H0V+UjQGP44jR/2/jse9tN0T+yis59NLW/oCaxSJFrXMdIJqdIIhospUM3uifcNnSsIQVLTpawd NJX0fYkyo4zsgw0iYsha0fyO68x5Jj7UP/avH40jVs0GpURHNTfSA54lBJ22FbSqFopcdlPTPTF2f W40tlM9Cpbvl3n+lwS16GWI8Hhe4VKYYFh02MjbguiAeDv5JScHO7p4fABJti7WYYcxP85TtJKYG+ mCvr5jmg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlTTa-0006uB-MI; Wed, 17 Jun 2020 08:31:18 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C68F3306102; Wed, 17 Jun 2020 10:31:16 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id AD21229E5A2E1; Wed, 17 Jun 2020 10:31:16 +0200 (CEST) Date: Wed, 17 Jun 2020 10:31:16 +0200 From: Peter Zijlstra To: Fenghua Yu Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , David Woodhouse , Lu Baolu , Frederic Barrat , Andrew Donnellan , Felix Kuehling , Joerg Roedel , Dave Hansen , Tony Luck , Ashok Raj , Jacob Jun Pan , Dave Jiang , Yu-cheng Yu , Sohil Mehta , Ravi V Shankar , linux-kernel , x86 , iommu@lists.linux-foundation.org, amd-gfx , linuxppc-dev Subject: Re: [PATCH v2 12/12] x86/traps: Fix up invalid PASID Message-ID: <20200617083116.GE2531@hirez.programming.kicks-ass.net> References: <1592008893-9388-1-git-send-email-fenghua.yu@intel.com> <1592008893-9388-13-git-send-email-fenghua.yu@intel.com> <20200615075649.GK2497@hirez.programming.kicks-ass.net> <20200615154854.GB13792@romley-ivt3.sc.intel.com> <20200615160357.GA2531@hirez.programming.kicks-ass.net> <20200615181259.GC13792@romley-ivt3.sc.intel.com> <20200615183116.GD2531@hirez.programming.kicks-ass.net> <20200615185529.GD13792@romley-ivt3.sc.intel.com> <20200615190928.GJ2531@hirez.programming.kicks-ass.net> <20200616232345.GC15763@romley-ivt3.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200616232345.GC15763@romley-ivt3.sc.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 04:23:46PM -0700, Fenghua Yu wrote: > Hi, Peter, > > On Mon, Jun 15, 2020 at 09:09:28PM +0200, Peter Zijlstra wrote: > > On Mon, Jun 15, 2020 at 11:55:29AM -0700, Fenghua Yu wrote: > > > > > Or do you suggest to add a random new flag in struct thread_info instead > > > of a TIF flag? > > > > Why thread_info? What's wrong with something simple like the below. It > > takes a bit from the 'strictly current' flags word. > > > > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > index b62e6aaf28f0..fca830b97055 100644 > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -801,6 +801,9 @@ struct task_struct { > > /* Stalled due to lack of memory */ > > unsigned in_memstall:1; > > #endif > > +#ifdef CONFIG_PCI_PASID > > + unsigned has_valid_pasid:1; > > +#endif > > > > unsigned long atomic_flags; /* Flags requiring atomic access. */ > > > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 142b23645d82..10b3891be99e 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -955,6 +955,10 @@ static struct task_struct *dup_task_struct(struct task_struct *orig, int node) > > tsk->use_memdelay = 0; > > #endif > > > > +#ifdef CONFIG_PCI_PASID > > + tsk->has_valid_pasid = 0; > > +#endif > > + > > #ifdef CONFIG_MEMCG > > tsk->active_memcg = NULL; > > #endif > > Can I add "Signed-off-by: Peter Zijlstra " > to this patch? I will send this patch in the next version of the series. Sure, n/p.