From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8887EC433E1 for ; Wed, 17 Jun 2020 11:36:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67A5F207DD for ; Wed, 17 Jun 2020 11:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592393802; bh=i3CHHkWt7uTtcIUvnX49srUPMnVlFyiU7GS37fP3xcM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=J7Hk/Pa24Ik3XpQ6Le/PnPzvj2+4w8tXrObti0yXSv9Mi4EWn8GAM73Fz5P4Iyd59 T7WBMiyEUUgoYKRGlYYbm/dgiRIDCIeFbx5S7uAsaQxeET2RmenMzRCxHCHFlRWVYA Lk+dVy6synMKaIBJluj/8C4xeCG8DAQNMKgI7kSE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726497AbgFQLgk (ORCPT ); Wed, 17 Jun 2020 07:36:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:53988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbgFQLgk (ORCPT ); Wed, 17 Jun 2020 07:36:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D6CE207DD; Wed, 17 Jun 2020 11:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592393798; bh=i3CHHkWt7uTtcIUvnX49srUPMnVlFyiU7GS37fP3xcM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0Bwomn1DFCBh+zuPVslZbNNswQt+pREc3VF2v/kD14PWS24GC78Aoq88ele/98rNi 7LTQjzh3AA8+JTORfKUlXbsrpF9NXaRtj8AzuWdRU9wvJXeZ9aKc7x9JT55SYh3EQ9 SN/X1YBbT7DVIMEjP5N78S6fOEViA3S5sofqJilE= Date: Wed, 17 Jun 2020 13:36:31 +0200 From: Greg Kroah-Hartman To: Steffen Maier Cc: Minchan Kim , Nitin Gupta , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Wade Mealing , Sergey Senozhatsky , Jens Axboe Subject: Re: [PATCH] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()" Message-ID: <20200617113631.GA2115184@kroah.com> References: <20200617103412.GA2027053@kroah.com> <5cde1d94-275e-2555-b13d-0b04a7a70fc7@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5cde1d94-275e-2555-b13d-0b04a7a70fc7@linux.ibm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2020 at 01:05:54PM +0200, Steffen Maier wrote: > On 6/17/20 12:34 PM, Greg Kroah-Hartman wrote: > > From: Wade Mealing > > > > Turns out that the permissions for 0400 really are what we want here, > > otherwise any user can write to this file. > > Minor confusion on my side: > Did you mean "read from" instead of "write to"? > I.e. only owner may read but not group nor others. > Whereas using CLASS_ATTR_RO would resolve into 0444. Sorry, you are correct, I'll fix the changelog text and send this out again. It's a "fun" file, reading from it causes something to happen, not the normal way things work :( greg k-h