From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 334FDC433DF for ; Wed, 17 Jun 2020 12:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1824D2098B for ; Wed, 17 Jun 2020 12:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726355AbgFQMYy (ORCPT ); Wed, 17 Jun 2020 08:24:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:48164 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbgFQMYx (ORCPT ); Wed, 17 Jun 2020 08:24:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1A860AAC6; Wed, 17 Jun 2020 12:24:55 +0000 (UTC) Date: Wed, 17 Jun 2020 14:24:50 +0200 From: Petr Mladek To: Peter Zijlstra Cc: Herbert Xu , Sergey Senozhatsky , Steven Rostedt , Linux Kernel Mailing List , Ingo Molnar , Will Deacon , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-s390@vger.kernel.org Subject: Re: [v3 PATCH 1/2] lockdep: Split header file into lockdep and lockdep_types Message-ID: <20200617122449.GX31238@alley> References: <20200617071524.GA3055@gondor.apana.org.au> <20200617082459.GC2531@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617082459.GC2531@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2020-06-17 10:24:59, Peter Zijlstra wrote: > On Wed, Jun 17, 2020 at 05:17:19PM +1000, Herbert Xu wrote: > > There is a header file inclusion loop between asm-generic/bug.h > > and linux/kernel.h. This causes potential compile failurs depending > > on the which file is included first. One way of breaking this loop > > is to stop spinlock_types.h from including lockdep.h. This patch > > splits lockdep.h into two files for this purpose. > > > > Signed-off-by: Herbert Xu > > Reviewed-by: Andy Shevchenko > > Reviewed-by: Sergey Senozhatsky > > Acked-by: Petr Mladek > > Acked-by: Steven Rostedt (VMware) > > Looks good. > > Petr, how about I stick this in tip/locking/header for us both to share? Sure. Sounds good to me. Best Regards, Petr