From: Willy Tarreau <w@1wt.eu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Wade Mealing <wmealing@redhat.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"
Date: Wed, 17 Jun 2020 14:31:00 +0200 [thread overview]
Message-ID: <20200617123100.GB852@1wt.eu> (raw)
In-Reply-To: <20200617103412.GA2027053@kroah.com>
Hi Greg,
On Wed, Jun 17, 2020 at 12:34:12PM +0200, Greg Kroah-Hartman wrote:
> From: Wade Mealing <wmealing@redhat.com>
>
> Turns out that the permissions for 0400 really are what we want here,
> otherwise any user can write to this file.
^^^^^^^^
s/write to/read from/
As Wade reported, it's sufficient to read from it to create a zram entry.
Regards,
Willy
next prev parent reply other threads:[~2020-06-17 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 10:34 [PATCH] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()" Greg Kroah-Hartman
2020-06-17 11:05 ` Steffen Maier
2020-06-17 11:36 ` Greg Kroah-Hartman
2020-06-17 11:49 ` [PATCH v2] " Greg Kroah-Hartman
2020-06-18 17:13 ` Steffen Maier
2020-06-23 7:03 ` Minchan Kim
2020-06-17 12:31 ` Willy Tarreau [this message]
2020-06-17 12:32 ` [PATCH] " Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617123100.GB852@1wt.eu \
--to=w@1wt.eu \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=wmealing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).