From: Andrew Morton <akpm@linux-foundation.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
axboe@kernel.dk, bfields@fieldses.org, chuck.lever@oracle.com,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
davem@davemloft.net, kuba@kernel.org, dhowells@redhat.com,
jarkko.sakkinen@linux.intel.com, jmorris@namei.org,
serge@hallyn.com, christian.brauner@ubuntu.com,
slyfox@gentoo.org, ast@kernel.org, keescook@chromium.org,
josh@joshtriplett.org, ravenexp@gmail.com, chainsaw@gentoo.org,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
bridge@lists.linux-foundation.org, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] kmod/umh: a few fixes
Date: Wed, 17 Jun 2020 17:43:48 -0700 [thread overview]
Message-ID: <20200617174348.70710c3ecb14005fb1b9ec39@linux-foundation.org> (raw)
In-Reply-To: <20200610154923.27510-1-mcgrof@kernel.org>
On Wed, 10 Jun 2020 15:49:18 +0000 "Luis R. Rodriguez" <mcgrof@kernel.org> wrote:
> Tiezhu Yang had sent out a patch set with a slew of kmod selftest
> fixes, and one patch which modified kmod to return 254 when a module
> was not found. This opened up pandora's box about why that was being
> used for and low and behold its because when UMH_WAIT_PROC is used
> we call a kernel_wait4() call but have never unwrapped the error code.
> The commit log for that fix details the rationale for the approach
> taken. I'd appreciate some review on that, in particular nfs folks
> as it seems a case was never really hit before.
>
> This goes boot tested, selftested with kmod, and 0-day gives its
> build blessings.
Any thoughts on which kernel version(s) need some/all of these fixes?
> drivers/block/drbd/drbd_nl.c | 20 +++++------
> fs/nfsd/nfs4recover.c | 2 +-
> include/linux/sched/task.h | 13 ++++++++
> kernel/kmod.c | 5 ++-
> kernel/umh.c | 4 +--
> lib/test_kmod.c | 2 +-
> net/bridge/br_stp_if.c | 10 ++----
> security/keys/request_key.c | 2 +-
> tools/testing/selftests/kmod/kmod.sh | 50 +++++++++++++++++++++++-----
I'm not really sure who takes kmod changes - I'll grab these unless
someone shouts at me.
next prev parent reply other threads:[~2020-06-18 0:43 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 15:49 [PATCH 0/5] kmod/umh: a few fixes Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 1/5] selftests: kmod: Use variable NAME in kmod_test_0001() Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 2/5] kmod: Remove redundant "be an" in the comment Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 3/5] test_kmod: Avoid potential double free in trigger_config_run_type() Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 4/5] umh: fix processed error when UMH_WAIT_PROC is used Luis R. Rodriguez
2020-06-23 14:11 ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-23 14:23 ` Christian Borntraeger
2020-06-24 11:11 ` Christian Borntraeger
2020-06-24 12:05 ` Luis Chamberlain
2020-06-24 13:17 ` Luis Chamberlain
2020-06-24 16:13 ` Luis Chamberlain
2020-06-24 14:43 ` Christoph Hellwig
2020-06-24 15:54 ` Christian Borntraeger
2020-06-24 16:09 ` Luis Chamberlain
2020-06-24 17:58 ` Christian Borntraeger
2020-06-24 18:09 ` Christian Borntraeger
2020-06-24 18:32 ` Christian Borntraeger
2020-06-24 18:37 ` Christian Borntraeger
2020-06-25 13:26 ` Christian Borntraeger
2020-06-26 2:54 ` Luis Chamberlain
2020-06-26 5:22 ` Christian Borntraeger
2020-06-26 9:00 ` Christoph Hellwig
2020-06-26 11:40 ` Luis Chamberlain
2020-06-26 11:50 ` Luis Chamberlain
2020-06-30 17:57 ` Luis Chamberlain
2020-07-01 10:08 ` Christian Borntraeger
2020-07-01 13:24 ` Tetsuo Handa
2020-07-01 13:53 ` Luis Chamberlain
2020-07-01 14:08 ` Tetsuo Handa
2020-07-01 15:38 ` Luis Chamberlain
2020-07-01 15:48 ` Christian Borntraeger
2020-07-01 15:58 ` Luis Chamberlain
2020-07-01 16:01 ` Christian Borntraeger
2020-07-02 4:26 ` Tetsuo Handa
2020-07-02 19:46 ` Luis Chamberlain
2020-07-03 0:52 ` Tetsuo Handa
2020-07-03 13:28 ` Luis Chamberlain
2020-07-01 15:26 ` Christian Borntraeger
2020-07-01 13:46 ` Luis Chamberlain
2020-06-10 15:49 ` [PATCH 5/5] selftests: simplify kmod failure value Luis R. Rodriguez
2020-06-18 0:43 ` Andrew Morton [this message]
2020-06-19 20:46 ` [PATCH 0/5] kmod/umh: a few fixes Luis Chamberlain
2020-06-19 21:07 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617174348.70710c3ecb14005fb1b9ec39@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bfields@fieldses.org \
--cc=bridge@lists.linux-foundation.org \
--cc=chainsaw@gentoo.org \
--cc=christian.brauner@ubuntu.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=philipp.reisner@linbit.com \
--cc=ravenexp@gmail.com \
--cc=roopa@cumulusnetworks.com \
--cc=serge@hallyn.com \
--cc=slyfox@gentoo.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).