linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: wg@grandegger.com, kernel@martin.sperl.org,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver
Date: Thu, 18 Jun 2020 17:36:15 +0530	[thread overview]
Message-ID: <20200618120615.GA3949@mani> (raw)
In-Reply-To: <fbbca009-3c53-6aa9-94ed-7e9e337c31a4@pengutronix.de>

Hi,

On 0611, Marc Kleine-Budde wrote:
> On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote:
> > Hello,
> > 
> > This series adds CAN network driver support for Microchip MCP25XXFD CAN
> > Controller with MCP2517FD as the target controller version. This series is
> > mostly inspired (or taken) from the previous iterations posted by Martin Sperl.
> > I've trimmed down the parts which are not necessary for the initial version
> > to ease review. Still the series is relatively huge but I hope to get some
> > reviews (post -rcX ofc!).
> > 
> > Link to the origial series posted by Martin:
> > https://www.spinics.net/lists/devicetree/msg284462.html
> > 
> > I've not changed the functionality much but done some considerable amount of
> > cleanups and also preserved the authorship of Martin for all the patches he has
> > posted earlier. This series has been tested on 96Boards RB3 platform by myself
> > and Martin has tested the previous version on Rpi3 with external MCP2517FD
> > controller.
> 
> I initially started looking at Martin's driver and it was not using several
> modern CAN driver infrastructures. I then posted some cleanup patches but Martin
> was not working on the driver any more. Then I decided to rewrite the driver,
> that is the one I'm hoping to mainline soon.
> 
> Can you give it a try?
> 
> https://github.com/marckleinebudde/linux/commits/v5.6-rpi/mcp25xxfd-20200607-41
> 

Tested this version on my board with MCP2518FD and it works fine. I'm okay with
moving forward with your version and would like to contribute. Please let me
know how we can move forward.

Thanks,
Mani

> Marc
> 
> -- 
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2020-06-18 12:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10  7:44 [PATCH 0/6] Add Microchip MCP25XXFD CAN driver Manivannan Sadhasivam
2020-06-10  7:44 ` [PATCH 1/6] dt-bindings: can: Document devicetree bindings for MCP25XXFD Manivannan Sadhasivam
2020-06-10  7:44 ` [PATCH 2/6] can: mcp25xxfd: Add Microchip MCP25XXFD CAN-FD driver infrastructure Manivannan Sadhasivam
2020-06-10  7:44 ` [PATCH 3/6] can: mcp25xxfd: Add support for CAN reception Manivannan Sadhasivam
2020-06-10  7:44 ` [PATCH 4/6] can: mcp25xxfd: Add CAN transmission support Manivannan Sadhasivam
2020-06-10  7:44 ` [PATCH 5/6] can: mcp25xxfd: Optimize TEF read by avoiding unnecessary SPI transfers Manivannan Sadhasivam
2020-06-10  7:44 ` [PATCH 6/6] MAINTAINERS: Add entry for Microchip MCP25XXFD CAN network driver Manivannan Sadhasivam
2020-06-11 16:26 ` [PATCH 0/6] Add Microchip MCP25XXFD CAN driver Marc Kleine-Budde
2020-06-11 20:30   ` Marc Kleine-Budde
2020-06-12 11:27     ` Marc Kleine-Budde
2020-06-17 16:59   ` Kurt Van Dijck
2020-06-17 22:36     ` Marc Kleine-Budde
2020-06-18 12:30       ` Kurt Van Dijck
2020-06-18 12:35         ` Marc Kleine-Budde
2020-06-22 10:25           ` Kurt Van Dijck
2020-06-22 10:55             ` Marc Kleine-Budde
2020-06-22 12:30               ` Kurt Van Dijck
2020-06-22 12:43                 ` Kurt Van Dijck
2020-06-22 12:54                   ` Marc Kleine-Budde
2020-06-22 13:26                     ` Kurt Van Dijck
2020-06-22 13:41                       ` Marc Kleine-Budde
2020-06-18  8:55   ` Manivannan Sadhasivam
2020-06-20  2:43     ` Manivannan Sadhasivam
2020-06-22 11:47     ` Marc Kleine-Budde
2020-06-18 12:06   ` Manivannan Sadhasivam [this message]
2020-06-22 11:41     ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618120615.GA3949@mani \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=kernel@martin.sperl.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).