From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411E4C433E0 for ; Thu, 18 Jun 2020 12:45:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2109C204EA for ; Thu, 18 Jun 2020 12:45:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="QOQCNoyk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729909AbgFRMpb (ORCPT ); Thu, 18 Jun 2020 08:45:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729805AbgFRMp0 (ORCPT ); Thu, 18 Jun 2020 08:45:26 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 344B9C06174E for ; Thu, 18 Jun 2020 05:45:26 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id c185so5304336qke.7 for ; Thu, 18 Jun 2020 05:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LyhtUXnS6mJ/BWitQdlXCfK/SHxOvdmee5AjGwVX+60=; b=QOQCNoykQbJg26yg+OrW8wdAHoME9+y7Kf8QfwwVrb9MFkHKffudy/6Ni3KLCEWc7g GHQTnpN8J1Z3ch4VEOf8PP7peeNMpmRei0FAAIH1rm7MpiLOP/gbA+h9jbmK1mO7/H4D 9GpxScuTUGp9/njrXbeXTMAGMWozXO4dAfUOTh+ch09cQoq4LfbTCHPOsTZzrnYGn2MR +v4uMt/6nSGTpUdRUIv2YztTkxv0dYVsu0GrqC6OAHXrfDb7FappnDKbPKJ/+3YoBKd4 YSNWd963n+kPpnrOTz15+P46sAfj5cpJf/oA2FAWWFHPGqyOcfEj2LOSER4QGoP6ive/ gfcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LyhtUXnS6mJ/BWitQdlXCfK/SHxOvdmee5AjGwVX+60=; b=GSYNbTyP2bs3FNm9azuXLnsrUl2bcgmqiBbFWMckKlfmip7urhNMxPI2iJjun/nx0N OXPiGXo3ts3UZqPfGxfsQGqpgDlS/NcLW3SHFUSUSocdkgdeI/g9SzudAacja2I5tKX8 89Xe20liS8wVru5171RM3/s+0YEmoINhF4FQwURqee1fvSoDFJbEFumq5IQu/grxxeWL NPFZvd6rQNZxp6uheEGWNNmsxfKPLMGQDvLUOViwjwKYeLipWvK2TEkiyFdcc8Y7x0D2 EOooISyYV2Q7Jbwu+uo19J4tFSd5WjKDhF80qZJdlSJeS0N+6QCSpsQc2emMV6oxtkQs /ztQ== X-Gm-Message-State: AOAM533vcZ+g+fUvspjRYe5vdsKgJ38HpA4soLqNGcrEU3IYVV+Q+xsr UwkJjgmyRl/Y4rcNYtEtlIL4Ig== X-Google-Smtp-Source: ABdhPJwjyb0VZyQanpzJoNo9ywQsJiOaSZ13I/hBiKWMy+ZzCkZFhywzJeX2GeleTnXxoqAZNtcPPQ== X-Received: by 2002:a37:bb43:: with SMTP id l64mr3454332qkf.271.1592484325487; Thu, 18 Jun 2020 05:45:25 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id 70sm2947841qkk.10.2020.06.18.05.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 05:45:24 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.93) (envelope-from ) id 1jltv2-00A2Sj-0s; Thu, 18 Jun 2020 09:45:24 -0300 Date: Thu, 18 Jun 2020 09:45:24 -0300 From: Jason Gunthorpe To: Aditya Pakki Cc: kjlu@umn.edu, wu000273@umn.edu, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , "Michael J. Ruhl" , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] RDMA/rvt: Fix potential memory leak caused by rvt_alloc_rq Message-ID: <20200618124524.GB2392687@ziepe.ca> References: <20200614041148.131983-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200614041148.131983-1-pakki001@umn.edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 13, 2020 at 11:11:48PM -0500, Aditya Pakki wrote: > In case of failure of alloc_ud_wq_attr(), the memory allocated by > rvt_alloc_rq() is not freed. Fix it by calling rvt_free_rq() using > the existing clean-up code. > > Fixes: d310c4bf8aea ("IB/{rdmavt, hfi1, qib}: Remove AH refcount for UD QPs") > Signed-off-by: Aditya Pakki > Acked-by: Dennis Dalessandro > --- > v1: Fix incorrect order of rvt_free_rq and free_ud_wq_attr. > Suggested by Dennis Dalessandro. > --- > drivers/infiniband/sw/rdmavt/qp.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied to for-rc, thanks Jason