From: Peter Zijlstra <peterz@infradead.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [v3 PATCH 1/2] lockdep: Split header file into lockdep and lockdep_types
Date: Thu, 18 Jun 2020 16:37:35 +0200 [thread overview]
Message-ID: <20200618143735.GJ576905@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200617122449.GX31238@alley>
On Wed, Jun 17, 2020 at 02:24:50PM +0200, Petr Mladek wrote:
> On Wed 2020-06-17 10:24:59, Peter Zijlstra wrote:
> > On Wed, Jun 17, 2020 at 05:17:19PM +1000, Herbert Xu wrote:
> > > There is a header file inclusion loop between asm-generic/bug.h
> > > and linux/kernel.h. This causes potential compile failurs depending
> > > on the which file is included first. One way of breaking this loop
> > > is to stop spinlock_types.h from including lockdep.h. This patch
> > > splits lockdep.h into two files for this purpose.
> > >
> > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > Acked-by: Petr Mladek <pmladek@suse.com>
> > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > Looks good.
> >
> > Petr, how about I stick this in tip/locking/header for us both to share?
>
> Sure. Sounds good to me.
OK, done. tip/locking/header should contain just this patch, and that
branch also got merged into tip/locking/core.
next prev parent reply other threads:[~2020-06-18 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 7:15 [v3 PATCH 0/2] Splitting ratelimit.h and lockdep.h Herbert Xu
2020-06-17 7:17 ` [v3 PATCH 1/2] lockdep: Split header file into lockdep and lockdep_types Herbert Xu
2020-06-17 8:24 ` Peter Zijlstra
2020-06-17 12:24 ` Petr Mladek
2020-06-18 14:37 ` Peter Zijlstra [this message]
2020-07-07 3:42 ` [PATCH RESEND] lockdep: Move list.h inclusion into lockdep.h Herbert Xu
2020-06-18 14:43 ` [tip: locking/core] lockdep: Split header file into lockdep and lockdep_types tip-bot2 for Herbert Xu
2020-06-17 7:17 ` [v3 PATCH 2/2] printk: Make linux/printk.h self-contained Herbert Xu
2020-06-17 7:58 ` Heiko Carstens
2020-06-19 9:31 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618143735.GJ576905@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).