From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Hemant Kumar <hemantk@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
jhugo@codeaurora.org, bbhatt@codeaurora.org
Subject: Re: [PATCH v3 1/4] bus: mhi: core: Add helper API to return number of free TREs
Date: Fri, 19 Jun 2020 11:01:25 +0530 [thread overview]
Message-ID: <20200619053125.GA3245@Mani-XPS-13-9360> (raw)
In-Reply-To: <1591899224-3403-2-git-send-email-hemantk@codeaurora.org>
On Thu, Jun 11, 2020 at 11:13:41AM -0700, Hemant Kumar wrote:
> Introduce mhi_get_no_free_descriptors() API to return number
> of TREs available to queue buffer. MHI clients can use this
> API to know before hand if ring is full without calling queue
> API.
>
> Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
> ---
> drivers/bus/mhi/core/main.c | 12 ++++++++++++
> include/linux/mhi.h | 9 +++++++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index d25f321..1bd3b1e 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -258,6 +258,18 @@ int mhi_destroy_device(struct device *dev, void *data)
> return 0;
> }
>
> +int mhi_get_no_free_descriptors(struct mhi_device *mhi_dev,
> + enum dma_data_direction dir)
How about "mhi_get_nr_free_descriptors"? Also align with '('
> +{
> + struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
> + struct mhi_chan *mhi_chan = (dir == DMA_TO_DEVICE) ?
> + mhi_dev->ul_chan : mhi_dev->dl_chan;
> + struct mhi_ring *tre_ring = &mhi_chan->tre_ring;
> +
> + return get_nr_avail_ring_elements(mhi_cntrl, tre_ring);
> +}
> +EXPORT_SYMBOL_GPL(mhi_get_no_free_descriptors);
> +
> void mhi_notify(struct mhi_device *mhi_dev, enum mhi_callback cb_reason)
> {
> struct mhi_driver *mhi_drv;
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 6af6bd6..a39b77d 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -602,6 +602,15 @@ void mhi_set_mhi_state(struct mhi_controller *mhi_cntrl,
> void mhi_notify(struct mhi_device *mhi_dev, enum mhi_callback cb_reason);
>
> /**
> + * mhi_get_no_free_descriptors - Get transfer ring length
Is the description correct? I'd suggest to just use the below one.
> + * Get # of TD available to queue buffers
How about, "Get # of available TREs to queue buffers"?
> + * @mhi_dev: Device associated with the channels
> + * @dir: Direction of the channel
> + */
> +int mhi_get_no_free_descriptors(struct mhi_device *mhi_dev,
> + enum dma_data_direction dir);
Align this with '('
Thanks,
Mani
> +
> +/**
> * mhi_prepare_for_power_up - Do pre-initialization before power up.
> * This is optional, call this before power up if
> * the controller does not want bus framework to
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-06-19 5:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 18:13 [PATCH v3 0/4] user space client interface driver Hemant Kumar
2020-06-11 18:13 ` [PATCH v3 1/4] bus: mhi: core: Add helper API to return number of free TREs Hemant Kumar
2020-06-19 5:31 ` Manivannan Sadhasivam [this message]
2020-06-11 18:13 ` [PATCH v3 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file Hemant Kumar
2020-06-19 5:33 ` Manivannan Sadhasivam
2020-06-25 0:03 ` Hemant Kumar
2020-06-11 18:13 ` [PATCH v3 3/4] docs: Add documentation for user space client interface Hemant Kumar
2020-06-19 6:39 ` Manivannan Sadhasivam
2020-06-25 1:52 ` Hemant Kumar
2020-06-25 6:23 ` Manivannan Sadhasivam
2020-06-25 6:27 ` Manivannan Sadhasivam
2020-06-11 18:13 ` [PATCH v3 4/4] bus: mhi: clients: Add user space client interface driver Hemant Kumar
2020-06-19 10:40 ` Manivannan Sadhasivam
2020-07-21 3:40 ` Hemant Kumar
2020-07-22 8:45 ` Manivannan Sadhasivam
2020-07-24 23:47 ` Hemant Kumar
2020-07-25 16:49 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619053125.GA3245@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).