From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C529FC433DF for ; Fri, 19 Jun 2020 16:11:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A68342168B for ; Fri, 19 Jun 2020 16:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592583080; bh=Ie2mvIvkGQbdrF3H2i6PnpLXDR6Dmda2raGGfUvNt4I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OcRPnUmcC2vonqo8pAgEj1FQrODKPk8oIPErMxNln2Y2mInsOjQHFxFqHdG2PNl2i iJrZAxbgxLsKPDjGi8FE2hZh56+GlIJGoTbJSCPa/NeAU0rTn1xOWHDwQOfD5ayhyO PAkv1e1Kbxs0oF0M6dx5aT4xPmAvFNdV3J+VeS7k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394345AbgFSQLS (ORCPT ); Fri, 19 Jun 2020 12:11:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:35076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391383AbgFSPGE (ORCPT ); Fri, 19 Jun 2020 11:06:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A980821835; Fri, 19 Jun 2020 15:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592579164; bh=Ie2mvIvkGQbdrF3H2i6PnpLXDR6Dmda2raGGfUvNt4I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qkC54sCSNu15kAvjnppSAzJeWU5oju+kGe+4euyjYwQt9BDl+GBLImbwcavTS7Wgl LHfJGDkdQjwUKj7pRmoHpj1aGmJwRK958djl0A8EF/yp/WWU9GUZyaMg1rvyjSV1et c9X7zcNwUsJJ6piDwrrtyXlrWUeLnCf1s7vBVvRI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Shevchenko , Dejin Zheng , Yan-Hsuan Chuang , Kalle Valo , Sasha Levin Subject: [PATCH 5.4 024/261] rtw88: fix an issue about leak system resources Date: Fri, 19 Jun 2020 16:30:35 +0200 Message-Id: <20200619141651.082531499@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141649.878808811@linuxfoundation.org> References: <20200619141649.878808811@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dejin Zheng [ Upstream commit 191f6b08bfef24e1a9641eaac96ed030a7be4599 ] the related system resources were not released when pci_iomap() return error in the rtw_pci_io_mapping() function. add pci_release_regions() to fix it. Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver") Cc: Andy Shevchenko Signed-off-by: Dejin Zheng Acked-by: Yan-Hsuan Chuang Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200504083442.3033-1-zhengdejin5@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtw88/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c index 77a2bdee50fa..4a43c4fa716d 100644 --- a/drivers/net/wireless/realtek/rtw88/pci.c +++ b/drivers/net/wireless/realtek/rtw88/pci.c @@ -974,6 +974,7 @@ static int rtw_pci_io_mapping(struct rtw_dev *rtwdev, len = pci_resource_len(pdev, bar_id); rtwpci->mmap = pci_iomap(pdev, bar_id, len); if (!rtwpci->mmap) { + pci_release_regions(pdev); rtw_err(rtwdev, "failed to map pci memory\n"); return -ENOMEM; } -- 2.25.1