From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D7BC433DF for ; Fri, 19 Jun 2020 16:50:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22264204EC for ; Fri, 19 Jun 2020 16:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592585400; bh=GhmndpCx0NtSvR5PEsSvK9su8y7F9B9W/85J59fhrTc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WDCDwIFjNmfc9cYZZ1K1OE+YMPpiI3sSMc8oYM+sb6XQXCgvjVtHPVzq75irpz9ne zvSLtn/V5krtOin5QL9vlc3BXKEOdEZ4m47zAx3XiF0tIN+Ri3CaDkfwvYNX0FkfEM xJMisFrD/WKlQglJmnFk/Ty9m6SrWaH2iOlL4D1w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405701AbgFSQt5 (ORCPT ); Fri, 19 Jun 2020 12:49:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:56470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387986AbgFSOjJ (ORCPT ); Fri, 19 Jun 2020 10:39:09 -0400 Received: from earth.universe (dyndsl-037-138-190-043.ewe-ip-backbone.de [37.138.190.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 673B320DD4; Fri, 19 Jun 2020 14:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592577548; bh=GhmndpCx0NtSvR5PEsSvK9su8y7F9B9W/85J59fhrTc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b6Q4n+E5Dk+L+BUYxW++OziNU6+ncxzIZSDlPwNkoW0CxkAggKh8nfcXgFXLzxuDx EJ/7nNdgDgcw81Mjo+PHn4VfVxOsxOopZmTnRo56r2nc44BOoraHqojrIopiFOUiUt vAjcvxaaljitJIN4Mfu9h37y+E93LduiyX1ThH3Q= Received: by earth.universe (Postfix, from userid 1000) id C348B3C08CD; Fri, 19 Jun 2020 16:39:06 +0200 (CEST) Date: Fri, 19 Jun 2020 16:39:06 +0200 From: Sebastian Reichel To: Krzysztof Kozlowski Cc: Rob Herring , Laurentiu Palcu , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt Message-ID: <20200619143906.33twapu6mgyay4yr@earth.universe> References: <20200617102305.14241-1-krzk@kernel.org> <20200617102305.14241-2-krzk@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gyqjsa47ulgkpkl2" Content-Disposition: inline In-Reply-To: <20200617102305.14241-2-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gyqjsa47ulgkpkl2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Jun 17, 2020 at 12:23:05PM +0200, Krzysztof Kozlowski wrote: > The driver requires interrupts (fails probe if it is not provided) so > document this requirement in bindings. >=20 > Fixes: 4aeae9cb0dad ("power_supply: Add support for TI BQ25890 charger ch= ip") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- Thanks, queued. -- Sebastian > Documentation/devicetree/bindings/power/supply/bq25890.txt | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b= /Documentation/devicetree/bindings/power/supply/bq25890.txt > index 51ecc756521f..3b4c69a7fa70 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq25890.txt > +++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt > @@ -10,6 +10,7 @@ Required properties: > * "ti,bq25895" > * "ti,bq25896" > - reg: integer, i2c address of the device. > +- interrupts: interrupt line; > - ti,battery-regulation-voltage: integer, maximum charging voltage (in u= V); > - ti,charge-current: integer, maximum charging current (in uA); > - ti,termination-current: integer, charge will be terminated when curren= t in > @@ -39,6 +40,9 @@ bq25890 { > compatible =3D "ti,bq25890"; > reg =3D <0x6a>; > =20 > + interrupt-parent =3D <&gpio1>; > + interrupts =3D <16 IRQ_TYPE_EDGE_FALLING>; > + > ti,battery-regulation-voltage =3D <4200000>; > ti,charge-current =3D <1000000>; > ti,termination-current =3D <50000>; > --=20 > 2.17.1 >=20 --gyqjsa47ulgkpkl2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl7szgoACgkQ2O7X88g7 +pobjw/8Cpw1OzyHiGjyxlvzVKNvp4LndLYSD4J8cdqGPeSNEAHae4sCqmae3G89 ZCd2Zohd2LwXXire9sQtIXJb96o+1ocWQIzR3wMIypCO8dy83IZqqy+SfZW4ivGW K2KmQChB/8os3O74Jw9DSPc4UfK0ISy+7HR4Ot8kyfhg1Dvm9z4NVnId2dHohXoL EOn4KYAvjSrevUfXSRwIadCxLxLW7dA1IV1+AS13p0XHdjq4OGQ5dsxNoqYd/X1Q MyF3f01Dfic0PDQE3StBTYKW8sYaXI73IftAxZ3gPTcPjS7AzFj+3wpXVEKjfxqR e7G40IJYwKtXiyIBg0aQhXOvC3/32LQV4c7suPNmNez4tSn6BkrnFvBOPiVeNZRq PLrFNdtatoX3otvbuJEoULD7jLIgSg3Oi8Fkbxu3zmpeCO8yNDPGTmZdhHyxfk7s xxUTNlOr7f5rbxYGVe2q0Vz7o5H6s5ukgjSsiqCSMZrNkJd2DYfnvPsSL6Ymd+jP SCdfiauLIwrXOzoX/lJXHj/fGzmJGUnU7ogW7OWqclWIGoTxAjIuen+lEWXNIjOH L/sAxLp/Sp1gS4rTRFJSite5x8A6h4QGxmsCN1mxuiKgeu9Lyrw4JmKEo40hYa8S Ayr385VFbX//luhm435eFe27tMPikUC1GdQwu/tFJk+mkoq5XVs= =XIWY -----END PGP SIGNATURE----- --gyqjsa47ulgkpkl2--