Hi Christophe, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-32s-Allocate-modules-outside-of-vmalloc-space-for-STRICT_KERNEL_RWX/20200620-001346 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-randconfig-r006-20200619 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 63700971ac9cdf198faa4a3a7c226fa579e49206) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from arch/powerpc/kernel/asm-offsets.c:14: In file included from include/linux/compat.h:10: In file included from include/linux/time.h:6: In file included from include/linux/seqlock.h:36: In file included from include/linux/spinlock.h:51: In file included from include/linux/preempt.h:78: In file included from ./arch/powerpc/include/generated/asm/preempt.h:1: In file included from include/asm-generic/preempt.h:5: In file included from include/linux/thread_info.h:21: In file included from arch/powerpc/include/asm/current.h:13: In file included from arch/powerpc/include/asm/paca.h:17: In file included from arch/powerpc/include/asm/lppaca.h:47: In file included from arch/powerpc/include/asm/mmu.h:348: In file included from arch/powerpc/include/asm/book3s/64/mmu.h:46: >> arch/powerpc/include/asm/book3s/64/mmu-hash.h:836:7: error: implicit declaration of function 'test_tsk_thread_flag' [-Werror,-Wimplicit-function-declaration] if (!is_kernel_addr(ea)) ^ arch/powerpc/include/asm/page.h:259:35: note: expanded from macro 'is_kernel_addr' #define is_kernel_addr(x) ((x) >= TASK_SIZE) ^ arch/powerpc/include/asm/task_size_64.h:51:19: note: expanded from macro 'TASK_SIZE' #define TASK_SIZE TASK_SIZE_OF(current) ^ arch/powerpc/include/asm/task_size_64.h:48:3: note: expanded from macro 'TASK_SIZE_OF' (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \ ^ In file included from arch/powerpc/kernel/asm-offsets.c:14: In file included from include/linux/compat.h:10: In file included from include/linux/time.h:6: In file included from include/linux/seqlock.h:36: In file included from include/linux/spinlock.h:51: In file included from include/linux/preempt.h:78: In file included from ./arch/powerpc/include/generated/asm/preempt.h:1: In file included from include/asm-generic/preempt.h:5: In file included from include/linux/thread_info.h:21: In file included from arch/powerpc/include/asm/current.h:13: In file included from arch/powerpc/include/asm/paca.h:17: In file included from arch/powerpc/include/asm/lppaca.h:47: In file included from arch/powerpc/include/asm/mmu.h:348: In file included from arch/powerpc/include/asm/book3s/64/mmu.h:46: >> arch/powerpc/include/asm/book3s/64/mmu-hash.h:836:7: error: use of undeclared identifier 'current' arch/powerpc/include/asm/page.h:259:35: note: expanded from macro 'is_kernel_addr' #define is_kernel_addr(x) ((x) >= TASK_SIZE) ^ arch/powerpc/include/asm/task_size_64.h:51:32: note: expanded from macro 'TASK_SIZE' #define TASK_SIZE TASK_SIZE_OF(current) ^ In file included from arch/powerpc/kernel/asm-offsets.c:14: In file included from include/linux/compat.h:10: In file included from include/linux/time.h:6: In file included from include/linux/seqlock.h:36: In file included from include/linux/spinlock.h:51: In file included from include/linux/preempt.h:78: In file included from ./arch/powerpc/include/generated/asm/preempt.h:1: In file included from include/asm-generic/preempt.h:5: In file included from include/linux/thread_info.h:21: In file included from arch/powerpc/include/asm/current.h:13: In file included from arch/powerpc/include/asm/paca.h:17: In file included from arch/powerpc/include/asm/lppaca.h:47: In file included from arch/powerpc/include/asm/mmu.h:348: In file included from arch/powerpc/include/asm/book3s/64/mmu.h:46: >> arch/powerpc/include/asm/book3s/64/mmu-hash.h:836:7: error: use of undeclared identifier 'TIF_32BIT' arch/powerpc/include/asm/page.h:259:35: note: expanded from macro 'is_kernel_addr' #define is_kernel_addr(x) ((x) >= TASK_SIZE) ^ arch/powerpc/include/asm/task_size_64.h:51:19: note: expanded from macro 'TASK_SIZE' #define TASK_SIZE TASK_SIZE_OF(current) ^ arch/powerpc/include/asm/task_size_64.h:48:29: note: expanded from macro 'TASK_SIZE_OF' (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \ ^ In file included from arch/powerpc/kernel/asm-offsets.c:14: In file included from include/linux/compat.h:15: In file included from include/linux/socket.h:8: In file included from include/linux/uio.h:10: In file included from include/crypto/hash.h:11: In file included from include/linux/crypto.h:21: In file included from include/linux/uaccess.h:5: >> include/linux/sched.h:1786:19: error: static declaration of 'test_tsk_thread_flag' follows non-static declaration static inline int test_tsk_thread_flag(struct task_struct *tsk, int flag) ^ arch/powerpc/include/asm/book3s/64/mmu-hash.h:836:7: note: previous implicit declaration is here if (!is_kernel_addr(ea)) ^ arch/powerpc/include/asm/page.h:259:35: note: expanded from macro 'is_kernel_addr' #define is_kernel_addr(x) ((x) >= TASK_SIZE) ^ arch/powerpc/include/asm/task_size_64.h:51:19: note: expanded from macro 'TASK_SIZE' #define TASK_SIZE TASK_SIZE_OF(current) ^ arch/powerpc/include/asm/task_size_64.h:48:3: note: expanded from macro 'TASK_SIZE_OF' (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \ ^ In file included from arch/powerpc/kernel/asm-offsets.c:21: include/linux/mman.h:133:9: warning: division by zero is undefined [-Wdivision-by-zero] _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/mman.h:111:21: note: expanded from macro '_calc_vm_trans' : ((x) & (bit1)) / ((bit1) / (bit2)))) ^ ~~~~~~~~~~~~~~~~~ include/linux/mman.h:134:9: warning: division by zero is undefined [-Wdivision-by-zero] _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/mman.h:111:21: note: expanded from macro '_calc_vm_trans' : ((x) & (bit1)) / ((bit1) / (bit2)))) ^ ~~~~~~~~~~~~~~~~~ 2 warnings and 4 errors generated. make[2]: *** [scripts/Makefile.build:114: arch/powerpc/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1188: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/test_tsk_thread_flag +836 arch/powerpc/include/asm/book3s/64/mmu-hash.h 4ffe713b7587b1 arch/powerpc/include/asm/book3s/64/mmu-hash.h Aneesh Kumar K.V 2018-09-20 828 c60ac5693c47df arch/powerpc/include/asm/mmu-hash64.h Aneesh Kumar K.V 2013-03-13 829 /* c60ac5693c47df arch/powerpc/include/asm/mmu-hash64.h Aneesh Kumar K.V 2013-03-13 830 * This is only valid for addresses >= PAGE_OFFSET c60ac5693c47df arch/powerpc/include/asm/mmu-hash64.h Aneesh Kumar K.V 2013-03-13 831 */ c60ac5693c47df arch/powerpc/include/asm/mmu-hash64.h Aneesh Kumar K.V 2013-03-13 832 static inline unsigned long get_kernel_vsid(unsigned long ea, int ssize) c60ac5693c47df arch/powerpc/include/asm/mmu-hash64.h Aneesh Kumar K.V 2013-03-13 833 { c60ac5693c47df arch/powerpc/include/asm/mmu-hash64.h Aneesh Kumar K.V 2013-03-13 834 unsigned long context; c60ac5693c47df arch/powerpc/include/asm/mmu-hash64.h Aneesh Kumar K.V 2013-03-13 835 85beb1c486df76 arch/powerpc/include/asm/book3s/64/mmu-hash.h Michael Ellerman 2017-03-29 @836 if (!is_kernel_addr(ea)) 85beb1c486df76 arch/powerpc/include/asm/book3s/64/mmu-hash.h Michael Ellerman 2017-03-29 837 return 0; 85beb1c486df76 arch/powerpc/include/asm/book3s/64/mmu-hash.h Michael Ellerman 2017-03-29 838 4ffe713b7587b1 arch/powerpc/include/asm/book3s/64/mmu-hash.h Aneesh Kumar K.V 2018-09-20 839 context = get_kernel_context(ea); c60ac5693c47df arch/powerpc/include/asm/mmu-hash64.h Aneesh Kumar K.V 2013-03-13 840 return get_vsid(context, ea, ssize); c60ac5693c47df arch/powerpc/include/asm/mmu-hash64.h Aneesh Kumar K.V 2013-03-13 841 } 5c3c7ede2bdcb8 arch/powerpc/include/asm/mmu-hash64.h David Gibson 2016-02-09 842 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org