From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: dt: fix oops on armada37xx
Date: Mon, 22 Jun 2020 07:51:37 +0530 [thread overview]
Message-ID: <20200622022137.f27ztstb5w3o43fe@vireshk-i7> (raw)
In-Reply-To: <20200620164449.GA19776@mail.rc.ru>
On 20-06-20, 17:44, Ivan Kokshaysky wrote:
> Commit 0c868627e617e43a295d8 (cpufreq: dt: Allow platform specific
> intermediate callbacks) added two function pointers to the
> struct cpufreq_dt_platform_data. However, armada37xx_cpufreq_driver_init()
> has this struct (pdata) located on the stack and uses only "suspend"
> and "resume" fields. So these newly added "get_intermediate" and
> "target_intermediate" pointers are uninitialized and contain arbitrary
> non-null values, causing all kinds of trouble.
>
> For instance, here is an oops on espressobin after an attempt to change
> the cpefreq governor:
>
> [ 29.174554] Unable to handle kernel execute from non-executable memory at virtual address ffff00003f87bdc0
> ...
> [ 29.269373] pc : 0xffff00003f87bdc0
> [ 29.272957] lr : __cpufreq_driver_target+0x138/0x580
> ...
>
> Fixed by zeroing out pdata before use.
>
> Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> ---
> drivers/cpufreq/armada-37xx-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c
> index aa0f06dec959..df1c941260d1 100644
> --- a/drivers/cpufreq/armada-37xx-cpufreq.c
> +++ b/drivers/cpufreq/armada-37xx-cpufreq.c
> @@ -456,6 +456,7 @@ static int __init armada37xx_cpufreq_driver_init(void)
> /* Now that everything is setup, enable the DVFS at hardware level */
> armada37xx_cpufreq_enable_dvfs(nb_pm_base);
>
> + memset(&pdata, 0, sizeof(pdata));
> pdata.suspend = armada37xx_cpufreq_suspend;
> pdata.resume = armada37xx_cpufreq_resume;
Applied. Thanks.
--
viresh
prev parent reply other threads:[~2020-06-22 2:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 16:44 [PATCH] cpufreq: dt: fix oops on armada37xx Ivan Kokshaysky
2020-06-20 17:54 ` Andrew Lunn
2020-06-20 19:10 ` Ivan Kokshaysky
2020-06-22 2:21 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622022137.f27ztstb5w3o43fe@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).